Skip to content
GitLab
  1. Mar 28, 2024
  3. Mar 27, 2024
    • Sebastian Berg's avatar
      feat: make `numpy.h` compatible with both NumPy 1.x and 2.x (#5050) · 705efcce
      Sebastian Berg authored 
      

* API: Make `numpy.h` compatible with both NumPy 1.x and 2.x

* TST: Update numpy dtype flags test to not covert flags to char

* API: Add `numpy2.h` instead and make `numpy.h` safe

This means that users of `numpy.h` cannot be broken, but need to
update to `numpy2.h` if they want to compile for NumPy 2.

Using Macros simply and didn't bother to try to remove unnecessary
code paths.

* API: Rather than `numpy2.h` use a define for the user.

* Thread `PYBIND11_NUMPY2_SUPPORT` through things and try to adept test matrix

* Small fixups (shouldn't matter)?

* Fixup.  Does upgrading scipy help?  (it shouldn't?)

(Some other small fixup)

* Use NumPy 2 nightlies for ubuntu-latest job also

* BUG: Fix numpy.bool check

* TST: Fix complexwarning

* BUG: Fix the fact that only the 50 slot is filled with the copy alias

(There were 3 functions all doing the same, only this slot survived 2.x)

* TST: One more test tweak

* TST: Use "long" name for long, since it changed on windows

* TST: Apparently we didn't always have ulong, so just use `L`

* TST: Enforce dtype='l' for test as default isn't long anymore on windows

* Rename macro and invert logic to PYBIND11_NUMPY_1_ONLY

* PYBIND11_INTERNAL_NUMPY_1_ONLY_DETECTED

* Test and code comment expansion

* CI: Use pre-releases of numpy/scipy from pip via explicit version

* CI: NumPy 2 only available on almalinux (as it is Python >=3.9)

* MAINT: Match name more exactly and adopt error phrasing

* MAINT: Pushed early, move helper to be private member

* fix error message compilation when using NumPy 1.x-only backcompat

* silence name shadowing warning

* chore: minor optimization

Signed-off-by: default avatarHenry Schreiner <henryschreineriii@gmail.com>

---------

Signed-off-by: default avatarHenry Schreiner <henryschreineriii@gmail.com>
Co-authored-by: default avatarRalf W. Grosse-Kunstleve <rwgk@google.com>
Co-authored-by: default avatarHenry Schreiner <henryschreineriii@gmail.com>
      705efcce
    • Henry Schreiner's avatar
      tests: hide warning on clang (#5069) · e0f2c715
      Henry Schreiner authored 
      

Signed-off-by: default avatarHenry Schreiner <henryschreineriii@gmail.com>
      e0f2c715
  5. Mar 21, 2024
  7. Feb 14, 2024
  9. Feb 06, 2024
  11. Jan 29, 2024
  13. Jan 17, 2024
  15. Jan 14, 2024
  17. Jan 08, 2024
  19. Jan 02, 2024
  21. Dec 30, 2023
  23. Dec 15, 2023
  25. Dec 14, 2023
  27. Dec 07, 2023
  29. Dec 06, 2023
  31. Nov 30, 2023
  33. Nov 28, 2023
  35. Nov 16, 2023
  37. Nov 09, 2023
    • Ralf W. Grosse-Kunstleve's avatar
      Fix a long-standing bug in the handling of Python multiple inheritance (#4762) · e250155a
      Ralf W. Grosse-Kunstleve authored 
      * Equivalent of https://github.com/google/clif/commit/5718e4d0807fd3b6a8187dde140069120b81ecef

* Resolve clang-tidy errors.

* Moving test_PPCCInit() first changes the behavior!

* Resolve new Clang dev C++11 errors:

```
The CXX compiler identification is Clang 17.0.0
```

```
pytypes.h:1615:23: error: identifier '_s' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
```

```
cast.h:1380:26: error: identifier '_a' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
```

* Resolve gcc 4.8.5 error:

```
pytypes.h:1615:12: error: missing space between '""' and suffix identifier
```

* Specifically exclude `__clang__`

* Snapshot of debugging code (does NOT pass pre-commit checks).

* Revert "Snapshot of debugging code (does NOT pass pre-commit checks)."

This reverts commit 1d4f9ff2632b32ddcb0dc7ecd0ab7a4ce4c15a4e.

* [ci skip] Order Dependence Demo

* Revert "[ci skip] Order Dependence Demo"

This reverts commit d37b5409d4e5b835620ccbb321a4e1ba89af315c.

* One way to deal with the order dependency issue. This is not the best way, more like a proof of concept.

* Move test_PC() first again.

* Add `all_type_info_add_base_most_derived_first()`, use in `all_type_info_populate()`

* Revert "One way to deal with the order dependency issue. This is not the best way, more like a proof of concept."

This reverts commit eb09c6c1b978208ceee40f05bbe75491b6ff8ad6.

* clang-tidy fixes (automatic)

* Add `is_redundant_value_and_holder()` and use to avoid forcing `__init__` overrides when they are not needed.

* Streamline implementation and avoid unsafe `reinterpret_cast<instance *>()` introduced with PR #2152

The `reinterpret_cast<instance *>(self)` is unsafe if `__new__` is mocked,
which was actually found in the wild: the mock returned `None` for `self`.
This was inconsequential because `inst` is currently cast straight back to
`PyObject *` to compute `all_type_info()`, which is empty if `self` is not
a pybind11 `instance`, and then `inst` is never dereferenced. However, the
unsafe detour through `instance *` is easily avoided and the updated
implementation is less prone to accidents while debugging or refactoring.

* Fix actual undefined behavior exposed by previous changes.

It turns out the previous commit message is incorrect, the `inst` pointer is actually dereferenced, in the `value_and_holder` ctor here:

https://github.com/pybind/pybind11/blob/f3e0602802c7840992c97f4960515777cad6a5c7/include/pybind11/detail/type_caster_base.h#L262-L263

```
259     // Main constructor for a found value/holder:
260     value_and_holder(instance *i, const detail::type_info *type, size_t vpos, size_t index)
261         : inst{i}, index{index}, type{type},
262           vh{inst->simple_layout ? inst->simple_value_holder
263                                  : &inst->nonsimple.values_and_holders[vpos]} {}
```

* Add test_mock_new()

* Experiment: specify indirect bases

* Revert "Experiment: specify indirect bases"

This reverts commit 4f90d85f9fc15290d6be54d5ae9417bd131b84d9.

* Add `all_type_info_check_for_divergence()` and some tests.

* Call `all_type_info_check_for_divergence()` also from `type_caster_generic::load_impl<>`

* Resolve clang-tidy error:

```
include/pybind11/detail/type_caster_base.h:795:21: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
                if (matching_bases.size() != 0) {
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
                    !matching_bases.empty()
```

* Revert "Resolve clang-tidy error:"

This reverts commit df27188dc6d6cf333145755543f56b2f6657aa5e.

* Revert "Call `all_type_info_check_for_divergence()` also from `type_caster_generic::load_impl<>`"

This reverts commit 5f5fd6a68e3cff1726628f6dea8e1c0754636a23.

* Revert "Add `all_type_info_check_for_divergence()` and some tests."

This reverts commit 0a9599f775bfd3ca196c5e23a3fcf2890cbf6e82.
      e250155a
    • Ralf W. Grosse-Kunstleve's avatar
      Fix refcount bug introduced with PR #4916. (#4927) · 2c35fde3
      Ralf W. Grosse-Kunstleve authored 
      https://github.com/pybind/pybind11/pull/4916/files#r1387035547
      2c35fde3
  39. Nov 08, 2023
  41. Nov 06, 2023