Skip to content
GitLab
  1. Jan 15, 2022
  3. Jan 12, 2022
  5. Jan 11, 2022
  7. Jan 10, 2022
  9. Jan 04, 2022
  11. Dec 30, 2021
  13. Dec 29, 2021
  15. Dec 28, 2021
  17. Dec 24, 2021
  19. Dec 22, 2021
  21. Dec 21, 2021
  23. Dec 14, 2021
    • Bobby Impollonia's avatar
      fix(setup_helpers): ensure ThreadPool is closed (#3548) · 75168113
      Bobby Impollonia authored 
      

* Ensure ThreadPool is closed in setup_helpers

The ParallelCompile setup helper using a ThreadPool to enable its
parallelism. It does not properly close the pool when it is done with
it.
This can lead to a "Exception ignored in: <function Pool.__del__..."
message with traceback being printed at shutdown.
Use pool.terminate() instead of context manager for Python 2.7
compatibility

* Add note to remove code that supports Python 2

Co-authored-by: default avatarBobby Impollonia <bobby@k13capital.com>
      75168113
  25. Dec 07, 2021
  27. Dec 04, 2021
    • Ralf W. Grosse-Kunstleve's avatar
      Tracking ci.yml changes from master. · 2675884d
      Ralf W. Grosse-Kunstleve authored
      2675884d
    • Ralf W. Grosse-Kunstleve's avatar
      Merge branch 'master' into sh_merge_master · 1418c65d
      Ralf W. Grosse-Kunstleve authored
      1418c65d
    • Boris Rasin's avatar
      fix: vs2022 compilation, issue #3477 (#3497) · a224d0cc
      Boris Rasin authored 
      

* fix: vs2022 compilation, issue #3477

* silence warning for python 2.7

* disable warning around mbstowcs call

* move disable warning code closer to call site

* turn on vs2022 ci test

* ci: don't run helpers on Windows 2022 & Python 3.5

* limit workaround for stdlib shipped with vs2022 or later

* fix for: limit workaround for stdlib shipped with vs2022 or later

* fix 2 for: limit workaround for stdlib shipped with vs2022 or later

* comment

* ci: add a Windows 2019 run

* ci: add Python 2.7 check too

Co-authored-by: default avatarHenry Schreiner <HenrySchreinerIII@gmail.com>
      a224d0cc
    • Ralf W. Grosse-Kunstleve's avatar
      Merge branch 'master' into smart_holder · d13e03af
      Ralf W. Grosse-Kunstleve authored
      d13e03af
    • Jason Rhinelander's avatar
      Expand std::string_view support to str, bytes, memoryview (#3521) · b4939fcb
      Jason Rhinelander authored 
      * Expand string_view support to str, bytes, memoryview

1. Allows constructing a str or bytes implicitly from a string_view;
   this is essentially a small shortcut allowing a caller to write
   `py::bytes{sv}` rather than `py::bytes{sv.data(), sv.size()}`.

2. Allows implicit conversion *to* string_view from py::bytes -- this
   saves a fair bit more as currently there is no simple way to get such
   a view of the bytes without copying it (or resorting to Python API
   calls).

   (This is not done for `str` because when the str contains unicode we
   have to allocate to a temporary and so there might not be some string
   data we can properly view without owning.)

3. Allows `memoryview::from_memory` to accept a string_view.  As with
   the other from_memory calls, it's entirely your responsibility to
   keep it alive.

This also required moving the string_view availability detection into
detail/common.h because this PR needs it in pytypes.h, which is higher
up the include chain than cast.h where it was being detected currently.

* Move string_view include to pytypes.h

* CI-testing a fix for the "ambiguous conversion" issue.

This change is known to fix the `tensorflow::tstring` issue reported under https://github.com/pybind/pybind11/pull/3521#issuecomment-985100965



TODO: Minimal reproducer for the `tensorflow::tstring` issue.

* Make clang-tidy happy (hopefully).

* Adding minimal reproducer for the `tensorflow::tstring` issue.

Error without the enable_if trick:

```
/usr/local/google/home/rwgk/forked/pybind11/tests/test_builtin_casters.cpp:169:16: error: ambiguous conversion for functional-style cast from 'TypeWithBothOperatorStringAndStringView' to 'py::bytes'
        return py::bytes(TypeWithBothOperatorStringAndStringView());
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../pytypes.h:1174:5: note: candidate constructor
    bytes(const std::string &s) : bytes(s.data(), s.size()) { }
    ^
/usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../pytypes.h:1191:5: note: candidate constructor
    bytes(std::string_view s) : bytes(s.data(), s.size()) { }
    ^
```

* Adding missing NOLINTNEXTLINE

* Also apply ambiguous conversion workaround to str()

Co-authored-by: default avatarRalf W. Grosse-Kunstleve <rwgk@google.com>
      b4939fcb
  29. Dec 03, 2021