Unverified Commit 75168113 authored by Bobby Impollonia's avatar Bobby Impollonia Committed by GitHub
Browse files

fix(setup_helpers): ensure ThreadPool is closed (#3548)



* Ensure ThreadPool is closed in setup_helpers

The ParallelCompile setup helper using a ThreadPool to enable its
parallelism. It does not properly close the pool when it is done with
it.
This can lead to a "Exception ignored in: <function Pool.__del__..."
message with traceback being printed at shutdown.
Use pool.terminate() instead of context manager for Python 2.7
compatibility

* Add note to remove code that supports Python 2

Co-authored-by: default avatarBobby Impollonia <bobby@k13capital.com>
parent 59aa9986
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment