- May 25, 2023
-
-
Mark de Wever authored
When using with clang-tidy 17 Node.getAttrName() sometimes returns a nullptr. This caused segfaults in the CI. Reviewed By: philnik, #libc Differential Revision: https://reviews.llvm.org/D151224
-
Kazu Hirata authored
The last uses were removed by: commit 772e4931 Author: Simon Tatham <simon.tatham@arm.com> Date: Thu Jan 23 11:53:27 2020 +0000 Differential Revision: https://reviews.llvm.org/D151299
-
- May 24, 2023
-
-
Matt Arsenault authored
-
Nikolas Klauser authored
Revert "[libc++] Apply _LIBCPP_EXCLUDE_FROM_EXPLICIT_INSTANTIATION only in classes that we have instantiated externally" This reverts commit b3c91500. There were unexpected breakages downstream. @EricWF is investigating.
-
Harsh Menon authored
In the tile and fuse of the first extract use, we add support for scenarios where the results of the tiled op have uses that are dominated by the scf.for_all. Specifically, we replace the scf.for_all with a new scf.for_all that has an additional shared_out and add the appropriate parallel insert slice op. Differential Revision: https://reviews.llvm.org/D151275
-
Vitaly Buka authored
Hooks are in malloc_hook.cpp.
-
Mark de Wever authored
The code has been quite ready for a while now and there are no more ABI breaking papers. So this is a good time to mark the feature as stable. Reviewed By: #libc, ldionne Differential Revision: https://reviews.llvm.org/D150802
-
Guillaume Chatelet authored
`getrandom` is implemented as a syscall. We don't want to test linux implementation of the syscall. We just want to verify that it reacts as expected to sensible values. Runtime before ``` [ RUN ] LlvmLibcGetRandomTest.InvalidFlag [ OK ] LlvmLibcGetRandomTest.InvalidFlag (took 0 ms) [ RUN ] LlvmLibcGetRandomTest.InvalidBuffer [ OK ] LlvmLibcGetRandomTest.InvalidBuffer (took 0 ms) [ RUN ] LlvmLibcGetRandomTest.ReturnsSize [ OK ] LlvmLibcGetRandomTest.ReturnsSize (took 83 ms) [ RUN ] LlvmLibcGetRandomTest.PiEstimation [ OK ] LlvmLibcGetRandomTest.PiEstimation (took 9882 ms) ``` Runtime after ``` [ RUN ] LlvmLibcGetRandomTest.InvalidFlag [ OK ] LlvmLibcGetRandomTest.InvalidFlag (took 0 ms) [ RUN ] LlvmLibcGetRandomTest.InvalidBuffer [ OK ] LlvmLibcGetRandomTest.InvalidBuffer (took 0 ms) [ RUN ] LlvmLibcGetRandomTest.ReturnsSize [ OK ] LlvmLibcGetRandomTest.ReturnsSize (took 0 ms) [ RUN ] LlvmLibcGetRandomTest.CheckValue [ OK ] LlvmLibcGetRandomTest.CheckValue (took 0 ms) ``` Reviewed By: lntue Differential Revision: https://reviews.llvm.org/D151336
-
Peter Klausler authored
SPACING() must return TINY() for zero arguments (which we do) and also for subnormal values smaller than TINY() in absolute value, which we get wrong. Fix folding and the runtime. Differential Revision: https://reviews.llvm.org/D151272
-
Christian Ulmann authored
This commit fixes a bug in the intrinsic base class that caused the declaration of alias analysis attributes under a wrong condition.
-
Valentin Clement authored
The destroy region is optional but the verifier was enforcing it. Update the verifier and make it clear in the definition. Reviewed By: razvanlupusoru Differential Revision: https://reviews.llvm.org/D151239
-
Luke Lau authored
For stores of small fixed-length vector constants, we can store them with a sequence of lui/addi/sh/sw to avoid the cost of building the vector and the vsetivli toggle, provided the constant materialization cost isn't too high. This subsumes the optimisation for stores of zeroes in 4dc9a2c5 (This is a reapply of 0ca13f9d) Reviewed By: reames Differential Revision: https://reviews.llvm.org/D151221
-
Philip Reames authored
-
Matt Arsenault authored
-
Matt Arsenault authored
-
Matthias Springer authored
Boolean compiler flags (such as `DMLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS`) show up in `mlir-config.h` as preprocessor defines that are either 0 or 1. Use `#if` instead of `#ifdef`. This should have been part of D144552.
-
Luke Lau authored
For stores of small fixed-length vector constants, we can store them with a sequence of lui/addi/sh/sw to avoid the cost of building the vector and the vsetivli toggle. Note that this only handles vectors that are 32 bits or smaller, but could be expanded to 64 bits if we know that the constant materialization cost isn't too high. Reviewed By: reames Differential Revision: https://reviews.llvm.org/D151221
-
Luke Lau authored
Reviewed By: craig.topper Differential Revision: https://reviews.llvm.org/D151220
-
Doru Bercea authored
Co-Author: Fabio Luporini <fabio@devitocodes.com> Review: https://reviews.llvm.org/D150134
-
Jie Fu authored
/data/llvm-project/llvm/lib/Transforms/Scalar/MergeICmps.cpp:623:21: error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigne d long') [-Werror,-Wsign-compare] for (int i = 0; i < Comparisons.size(); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~ 1 error generated. -
Matthias Springer authored
Compute operation finger prints to detect incorrect API usage in RewritePatterns. Does not work for dialect conversion patterns. Detect patterns that: * Returned `failure` but changed the IR. * Returned `success` but did not change the IR. * Inserted/removed/modified ops, bypassing the rewriter. Not all cases are detected. These new checks are quite expensive, so they are only enabled with `-DMLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS=ON`. Failures manifest as fatal errors (`llvm::report_fatal_error`) or crashes (accessing deallocated memory). To get better debugging information, run `mlir-opt -debug` (to see which pattern is broken) with ASAN (to see where memory was deallocated). Differential Revision: https://reviews.llvm.org/D144552
-
Jay Foad authored
Live intervals for physical registers are calculated lazily on demand. In a case like this: 16B %0:gpr32 = IMPLICIT_DEF 32B $wzr = COPY %0 if the live interval for $wzr did not already exist then the update code in joinReservedPhysReg would create it with a definition at 32B, which would remain even after the COPY was deleted. Differential Revision: https://reviews.llvm.org/D151314
-
Jay Foad authored
Differential Revision: https://reviews.llvm.org/D149947
-
Zhongyunde authored
1.Fix the last runtime issue as some sequent comparisons need be spilted. For the origin equal comparisons chain, the new spilted Icmp chain will still be end with equal, while for the new not-equal comparisons chain, the new spilted Icmp chain will still be end with equal, so should address this carefully, see detail wih case partial_sequent_ne 2. Fix the mismatch of last link comparison Thanks for @aeubanks, @glandium and @ayzhao report the runtime issue and carefully examine. Fix https://github.com/llvm/llvm-project/issues/59740. Reviewed By: vitalybuka Differential Revision: https://reviews.llvm.org/D141188
-
Matthias Springer authored
Do not duplicate code that is performing actual work, put debug code around it. Differential Revision: https://reviews.llvm.org/D151207
-
Jay Foad authored
When the scavenger is not allowed to spill, the only difference between forward and backward should be the heuristics used to pick an available register. Forwards scavenging tries to pick a register that can be used again later in the BB; backwards scavenging tries to pick one that can be used earlier. Backwards scavenging is preferred because it does not rely on accurate kill flags. Differential Revision: https://reviews.llvm.org/D151323
-
Sheng authored
A buildbot has failed on the absence of the blank line at the end of the bullet list.
-
Sheng authored
The type alias template is not diagnosed when instantiating an expected non-type template argument in a dependent scope, causing ICE. Besides that, the diagnostic message has been updated to account for the fact that the function template is not the only non-type template. Fixes #62533 Reviewed By: #clang-language-wg, erichkeane Differential Revision: https://reviews.llvm.org/D151062
-
Hansang Bae authored
The interop API routines try to invoke external entries, but we did not have support for KMP_DLSYM_NEXT on Windows. Also added proper guards for STUB build. Differential Revision: https://reviews.llvm.org/D149892
-
Clement Courbet authored
Correct link is clang-tidy/checks/performance/no-automatic-move
-
Clement Courbet authored
Fix bad link to documentation.
-
Matthias Springer authored
This allows subclasses (such as the ErrorCheckingTrackingListener in IREE) to produce better error messages. Differential Revision: https://reviews.llvm.org/D151322
-
Krzysztof Parzyszek authored
-
Krzysztof Parzyszek authored
Only the last instruction was remapped before.
-
Clement Courbet authored
We were only handling `const T&`/`T&&` ctor pairs, and we were missing uref-based ctors. Differential Revision: https://reviews.llvm.org/D151092
-
Matthias Springer authored
The following ops currently have the same finger print, even though they are different: ``` func.func @test() { "test.foo"() ({ "test.bar"() : () -> () }) : () -> () } ``` And: ``` func.func @test() { "test.bar"() : () -> () "test.foo"() ({ }) : () -> () } ``` The SHA1 hash used in OperationFingerPrint is order-sensitive, but the ops are hashed in the same order (post-order traversal), so the hash is the same. Switching to pre-order traversal does not solve the issue; a similar example, where IR differs just in its nesting structure, can be constructed. The problem is solved by hashing the parent op pointer. (Alternatively, a traversal over the IR that hashes scope markers (`{}`) could be used.) Differential Revision: https://reviews.llvm.org/D151306 -
Tue Ly authored
Reviewed By: gchatelet Differential Revision: https://reviews.llvm.org/D151256
-
Takuya Shimizu authored
This patch makes `-Wshadow` warn about the shadowings by static local variables. Fixes https://github.com/llvm/llvm-project/issues/62850 Differential Revision: https://reviews.llvm.org/D151214
-
Takuya Shimizu authored
Reland: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables This patch improves the diagnostic on uninitialized subobjects in constexpr variables by modifying the diagnostic message to display the subobject's name instead of its type. Fixes https://github.com/llvm/llvm-project/issues/58601 Differential Revision: https://reviews.llvm.org/D146358
-