- Apr 21, 2020
-
-
Uday Bondhugula authored
Summary: Improve the checks and drop redundant ones. Rename the outlined maps better. Reviewers: andydavis1, nicolasvasilache Subscribers: mehdi_amini, rriddle, jpienaar, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, Joonsoo, grosul1, frgossen, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D78514
-
Mircea Trofin authored
Summary: The CallSite arg iterator is really User::op_iterator. Reviewers: dblaikie, craig.topper Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D78507
-
Uday Bondhugula authored
Fix intra-tile upper bound setting in a scenario where the tile size was larger than the trip count. Differential Revision: https://reviews.llvm.org/D78505
-
Erik Pilkington authored
This fixes a common mistake (the 3 should be @3): NSNumber *n = 3. This extends an existing check for NSString. Also, this only errs if the initializer isn't a null pointer constant, so NSNumber *n = 0; continues to work. rdar://47029572 Differential revision: https://reviews.llvm.org/D78066
-
Sam McCall authored
Summary: This seems like a pretty safe case, and common enough to be useful. Reviewers: hokein Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D78338
-
Chris Bowler authored
-
Eli Friedman authored
This will allow us to use the datalayout to disambiguate other constructs in IR, like load alignment. Split off from D78403. Differential Revision: https://reviews.llvm.org/D78413
-
Jonas Devlieghere authored
This wasn't a great idea to begin with, as you can't really rely on the implementation, but since it also doesn't work with MSVC I've just made the ctors public.
-
David Tenty authored
Summary: r13 isn't reserved on 32-bit AIX, which is reflected in our calling convention but not callee saved regs. Reviewers: sfertile, ZarkoCA, cebowleratibm, jasonliu Reviewed By: sfertile Subscribers: thakis, lei, wuzish, nemanjai, hiraditya, kbarton, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D77101
-
Nemanja Ivanovic authored
We call the function that attempts to reuse the conversion without checking whether the target matches the constraints that the callee expects. This patch adds the check prior to the call. Fixes: https://bugs.llvm.org/show_bug.cgi?id=43976 Differential revision: https://reviews.llvm.org/D77564
-
Louis Dionne authored
-
David Green authored
-
Rumeet Dhindsa authored
This reverts commit e62dc1f6. Reverting as per discussion with the patch author. This patch causes module import error, but there was no intended behavior change for code that does not use Microsoft extensions.
-
Craig Topper authored
Differential Revision: https://reviews.llvm.org/D78475
-
Zola Bridges authored
Summary: This patch add the dataflow option to LLVM_USE_SANITIZER and documents it. Tested via check-cxx (wip to fix the errors). Reviewers: morehouse, #libc! Subscribers: mgorny, cfe-commits, libcxx-commits Tags: #clang, #libc Differential Revision: https://reviews.llvm.org/D78390
-
Sean Fertile authored
-
David Tenty authored
This reverts commit 6c881bf1.
-
Oliver Stannard authored
This started failing after an OS upgrade on a buildbot machine, and I don't see anything obvious to fix or revert, so disable it for now to get the bot green. Covered by https://bugs.llvm.org/show_bug.cgi?id=44158 Differential revision: https://reviews.llvm.org/D78496
-
Jonas Devlieghere authored
Support passive replay as proposed in the RFC [1] on lldb-dev and described in more detail on the lldb website [2]. This patch extends the LLDB_RECORD macros to re-invoke the current function with arguments deserialized from the reproducer. This relies on the function being called in the exact same order as during replay. It uses the same mechanism to toggle the API boundary as during recording, which guarantees that only boundary crossing calls are replayed. Another major change is that before this patch we could ignore the result of an API call, because we only cared about the observable behavior. Now we need to be able to return the replayed result to the SWIG bindings. We reuse a lot of the recording infrastructure, which can be a little confusing. We kept the existing naming to limit the amount of churn, but might revisit that in a future patch. [1] http://lists.llvm.org/pipermail/lldb-dev/2020-April/016100.html [2] https://lldb.llvm.org/resources/reproducers.html Differential revision: https://reviews.llvm.org/D77602
-
Nikita Popov authored
Following the rule of five, declare move constructor and move assignment operator for ValueLatticeElement. This allows moving the ConstantRange rather than copying it. This does not matter in most cases, where we're dealing with APInts <= 64 bits. It does avoid unnecessary copies of allocations for larger APInts. Additionally we change the implementation approach to make the copy/move assignment operators make use of the copy/move constructors, rather than the other way around. The constructors are the more primitive operations. Differential Revision: https://reviews.llvm.org/D78425
-
Nikita Popov authored
Use Instruction::comesBefore() instead of OrderedInstructions inside InstructionPrecedenceTracking. This also removes the dominator tree dependency. Differential Revision: https://reviews.llvm.org/D78461
-
Zola Bridges authored
Summary: When I read this on the website it looks like the `--` in the used font turns into an em dash. I updated this with inline literal mark up so the `--` will remain obvious. Reviewers: EricWF, #libc! Subscribers: libcxx-commits Tags: #libc Differential Revision: https://reviews.llvm.org/D78405
-
Sean Fertile authored
Adds support for passing a ByVal formal argument completely on the stack (ie after all argument registers are exhausted). Differential Revision: https://reviews.llvm.org/D78263
-
Jonas Devlieghere authored
Add two modes to the reproducer replay script that make debugging a little easier. Verbose mode prints stdout and stderr, regardless of whether replay was successful. When --failure-only is passed, output is limited to tests that failed to replay.
-
Sander de Smalen authored
This implements zeroing of false lanes for binary operations, where instead of merging into the first operand vector (_m) a `select` is placed on the first input vector. This approach easily translates to the use of the `zeroing movprfx` instruction. This patch also adds builtins for svabd, svadd, svdiv, svdivr, svmax, svmin, svmul, svmulh, svub and svsubr. Reviewers: SjoerdMeijer, efriedma, rovka Reviewed By: efriedma Tags: #clang Differential Revision: https://reviews.llvm.org/D77593
-
- Apr 20, 2020
-
-
Lei Zhang authored
Differential Revision: https://reviews.llvm.org/D78044
-
Lei Zhang authored
-
Lei Zhang authored
memref types with dynamic dimensions do not have a compile-time known size. They should be mapped to SPIR-V runtime array types. Differential Revision: https://reviews.llvm.org/D78197
-
Julian Lettner authored
We can use `simctl spawn --standalone` to enable running tests without the need for an already-booted simulator instance. This also side-steps the problem of not having a good place to shutdown the instance after we are finished with testing. rdar://58118442 Reviewed By: delcypher Differential Revision: https://reviews.llvm.org/D78409
-
Florian Hahn authored
DelSet was used to avoid invalidating the current iterator while modifying the map we are iterating over. By using an early_inc_range, (which increments to iterator 'early', allowing us to remove the current element), we can get rid of DelSet. Reviewers: gilr, rengolin, Ayal, hsaito Reviewed By: Ayal Differential Revision: https://reviews.llvm.org/D78420
-
Sam McCall authored
Summary: This is guaranteed to be a no-op without the preamble, so should be a no-op with it too. Partially fixes https://github.com/clangd/clangd/issues/337 This doesn't yet work for #ifndef guards, which are not recognized in preambles. see D78038 I can't for the life of me work out how to test this outside clangd. The original reentrant preamble diagnostic was untested, I added a test to clangd for that too. Reviewers: kadircet Subscribers: ilya-biryukov, jkorous, arphaman, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D78366
-
Sander de Smalen authored
Builtins that have the merge type MergeAnyExp or MergeZeroExp, merge into a 'undef' or 'zero' vector respectively, which enables the _x and _z behaviour for unary operations. This patch also adds builtins for svabs and svneg. Reviewers: SjoerdMeijer, efriedma, rovka Reviewed By: efriedma Tags: #clang Differential Revision: https://reviews.llvm.org/D77591
-
David Tenty authored
Summary: r13 isn't reserved on 32-bit AIX, which is reflected in our calling convention but not callee saved regs. Reviewers: sfertile, ZarkoCA, cebowleratibm, jasonliu Reviewed By: sfertile Subscribers: lei, wuzish, nemanjai, hiraditya, kbarton, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D77101
-
Alexander Belyaev authored
https://llvm.discourse.group/t/rfc-add-std-atomic-rmw-op/489 Differensial revision: https://reviews.llvm.org/D78352
-
Petre-Ionut Tudor authored
This reverts commit cabfcf84. The patch introduced another bug in the optimization.
-
Simon Pilgrim authored
Push MBFIWrapper.h include down to BranchFolding.cpp/IfConversion.cpp
-
Simon Pilgrim authored
Replace with forward declarations or push down to MIRVRegNamerUtils.cpp where necessary.
-
Fangrui Song authored
D77522 changed --warn-backrefs to not warn for linking sandwich problems (-ldef1 -lref -ldef2). This removed lots of false positives. However, glibc still has some problems. libc.a defines some symbols which are normally in libm.a and libpthread.a, e.g. __isnanl/raise. For a linking order `-lm -lpthread -lc`, I have seen: ``` // different resolutions: GNU ld/gold select libc.a(s_isnan.o) as the definition backward reference detected: __isnanl in libc.a(printf_fp.o) refers to libm.a(m_isnanl.o) // different resolutions: GNU ld/gold select libc.a(raise.o) as the definition backward reference detected: raise in libc.a(abort.o) refers to libpthread.a(pt-raise.o) ``` To facilitate deployment of --warn-backrefs, add --warn-backrefs-exclude= so that certain known issues (which may be impractical to fix) can be whitelisted. Deliberate choices: * Not a comma-separated list (`--warn-backrefs-exclude=liba.a,libb.a`). -Wl, splits the argument at commas, so we cannot use commas. --export-dynamic-symbol is similar. * Not in the style of `--warn-backrefs='*' --warn-backrefs=-liba.a`. We just need exclusion, not inclusion. For easier build system integration, we should avoid order dependency. With the current scheme, we enable --warn-backrefs, and indivial libraries can add --warn-backrefs-exclude=<glob> to their LDFLAGS. Reviewed By: psmith Differential Revision: https://reviews.llvm.org/D77512
-
Tom Weaver authored
Add DebuggerControllerBase and DefaultController to Dexter implements a new architecture that supports new and novel ways of running a debugger under dexter. Current implementation adds the original default behaviour via the new architecture via the DefaultController, this should have NFC. Reviewers: Orlando Differential Revision: https://reviews.llvm.org/D76926
-
Louis Dionne authored
We previously tried re-exporting symbols that didn't exist when exceptions were disabled. Note that building libc++abi without exceptions still doesn't work when linking against the default-provided libSystem.dylib, because it transitively depends on libobjc.dylib, and that requires __gxx_personality_v0. But building libc++abi with exceptions and libc++ without exceptions does work.
-