- May 16, 2020
-
-
Hubert Tong authored
Summary: If `DEFAULT_SYSROOT` is configured to some path, some tests would fail. This patch overrides `sysroot` to be the empty string in the style of D66834 so that the tests will pass even when the build is configured with a `DEFAULT_SYSROOT`. Reviewed By: mstorsjo Differential Revision: https://reviews.llvm.org/D79694
-
Stephen Neuendorffer authored
Also, missing MLIRTransforms as a dependency. This breaks BUILD_SHARED_LIBS=on Differential Revision: https://reviews.llvm.org/D80035
-
Fangrui Song authored
Omitting comments can make the output much smaller. Size/time impact on my machine: * lib/Target/AArch64/AArch64GenDAGISel.inc, 10MiB (8.89s) -> 5MiB (3.20s) * lib/Target/X86/X86GenDAGISel.inc, 20MiB (6.48s) -> 8.5MiB (4.18s) In total, this change decreases lib/Target/*/*GenDAGISel.inc from 71.4MiB to 30.1MiB. As rnk suggested, we can consider an option next to LLVM_OPTIMIZED_TABLEGEN once we have more needs like this. Reviewed By: thakis Differential Revision: https://reviews.llvm.org/D78884
-
Vitaly Buka authored
-
Nico Weber authored
In the CMake build, the HAVE_ vars are set based on system inspection, and LLVM_ENABLE_ZLIB is set to false if neither's found. The GN build doesn't do autodetection like this. With this change, people can set llvm_enable_zlib=true on Windows and as long as they provide a zlib.lib things should actually work. (https://reviews.llvm.org/D79219 will remove 2 of the 3 config.h values, hopefully soon. This change here just makes things a tiny bit easier until that change is in.)
-
Med Ismail Bennani authored
This patch introduces the `(-h|--host)` option to the `platform shell` command. It allows the user to run shell commands from the host platform (always available) without putting lldb in the background. Since the default behaviour of `platform shell` is to run the command of the selected platform, having such a choice can be quite handy when debugging remote targets, for instances. This patch also introduces a `shell` alias, to improve the command discoverability and make it more convenient to use for the user. rdar://62856024 Differential Revision: https://reviews.llvm.org/D79659 Signed-off-by:
Med Ismail Bennani <medismail.bennani@gmail.com>
-
Med Ismail Bennani authored
This patch improves data formatting for CFDictionaryRef and CFSetRef. It uses the same data-formatter as NSCFDictionaries and NSCFSets introduced previously but did require some adjustments in Core::ValueObject. Since the "Ref" types are opaque pointers to the actual CF containers, if the value object has a synthetic value, lldb will use the opaque pointer's pointee type to create the new ValueObjectChild needed to dereference the ValueObject. This allows the "Ref" types to behaves the same as CF containers when used with the `frame variable` command, the SBAPI or in Xcode's variable inspector. This patch also adds support for incomplete types in ValueObject. rdar://53104287 Differential Revision: https://reviews.llvm.org/D79554 Signed-off-by:
Med Ismail Bennani <medismail.bennani@gmail.com>
-
mydeveloperday authored
Summary: https://bugs.llvm.org/show_bug.cgi?id=44345 When namespaces get long the namespace end comment wraps onto the next line ``` namespace would::it::save::you::a::lot::of::time::if_::i::just::gave::up::and_:: went::mad::now { void foo(); void bar(); } // namespace // would::it::save::you::a::lot::of::time::if_::i::just::gave::up::and_::went::mad::now ``` If clang-format it applied successively it will duplicate the end comment ``` namespace would::it::save::you::a::lot::of::time::if_::i::just::gave::up::and_:: went::mad::now { void foo(); void bar(); } // namespace // would::it::save::you::a::lot::of::time::if_::i::just::gave::up::and_::went::mad::now // would::it::save::you::a::lot::of::time::if_::i::just::gave::up::and_::went::mad::now ``` This revision checks to ensure the end comment is not on the next line before adding yet another comment Reviewed By: krasimir Subscribers: cfe-commits Tags: #clang, #clang-format Differential Revision: https://reviews.llvm.org/D79935
-
Christopher Tetreault authored
Reviewers: efriedma, fpetrogalli, kmclaughlin, grosbach, dmgreen Reviewed By: dmgreen Subscribers: tschuett, kristof.beyls, hiraditya, rkruppe, psnobl, dmgreen, danielkiss, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D79816
-
Siva Chandra Reddy authored
Reviewers: phosek Differential Revision: https://reviews.llvm.org/D79149
-
Christopher Tetreault authored
Reviewers: efriedma, sdesmalen, c-rhodes, hfinkel Reviewed By: c-rhodes Subscribers: wuzish, nemanjai, tschuett, hiraditya, kbarton, rkruppe, psnobl, shchenz, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D79821
-
Mircea Trofin authored
This reverts commit 454de99a. The problem was that one of the ctor arguments of CallAnalyzer was left to be const std::function<>&. A function_ref was passed for it, and then the ctor stored the value in a function_ref field. So a std::function<> would be created as a temporary, and not survive past the ctor invocation, while the field would. Tested locally by following https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild Original Differential Revision: https://reviews.llvm.org/D79917
-
Eli Friedman authored
This is D77454, except for stores. All the infrastructure work was done for loads, so the remaining changes necessary are relatively small. Differential Revision: https://reviews.llvm.org/D79968
-
Zola Bridges authored
Summary: I forgot to include a test in this commit: https://reviews.llvm.org/rG379e68a763097bed55556c6dc7453e4b732e3d68 Here's the test. It passes after that commit and fails before that commit. Reviewed By: mattdr Differential Revision: https://reviews.llvm.org/D79894
-
Scott Linder authored
This has been duplicated since before 2372a193, but that commit has it appearing twice in the space of 10 lines of the same function body. It could also be hoisted up to the point just after where the last special-case is considered, but I want to keep the intent of the original authors. Committed as obvious without a review.
-
Thomas Lively authored
Summary: This new custom DAG combine fixes a codegen issue with the wasm_simd128.h intrinsics. Clang lowers the return (v128_t)(__f32x4){__a, __a, __a, __a}; body of f32x4_splat to a splat shuffle of a bitcasted vector, as seen in the new simd-shuffle-bitcast.ll test. The bitcast interfered with the target-independent DAG combine that combines splat shuffles into BUILD_VECTOR nodes, so this patch introduces a new custom DAG combine to hoist the bitcast out of the shuffle, allowing the target-independent combine to work as intended. Reviewers: aheejin, dschuff Subscribers: sbc100, jgravelle-google, hiraditya, sunfish, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D80021 -
Hongtao Yu authored
This is fixing a thinLTO module collision issue for thin archives. The problem is that we always use a zero offset to name members in a thin archive and that causes the following build error: ld.lld: error: Expected at most one ThinLTO module per bitcode file which happens to a thin archive that has two members with the same object file name (whose paths will be ignored by thinLTO driver) The fix here is to use real member offset instead as is done for non-thin archives. Differential Revision: https://reviews.llvm.org/D79880 -
Eli Friedman authored
This unifies SETCC operations along the lines of other operations. Differential Revision: https://reviews.llvm.org/D79975
-
Christopher Tetreault authored
Reviewers: deadalnix, efriedma, rengolin, jyknight, joerg Reviewed By: joerg Subscribers: tschuett, hiraditya, rkruppe, psnobl, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D79915
-
Matt Arsenault authored
This should not be allowed to change the address space of the source and result, so the pointer types should match. The only emitter of this seems to be a disable clang change, so no tests to update.
-
Daniel Grumberg authored
-
Jinsong Ji authored
Only add CMAKE_EXE_LINKER_FLAGS when in a standalone bulid. Or else CMAKE_EXE_LINKER_FLAGS contains flags for build compiler of Clang/llvm. This might not be the same as what the COMPILER_RT_TEST_COMPILER supports. eg: the build compiler use lld linker and we use it to build clang with default ld linker then to be tested clang will complain about lld options like --color-diagnostics. Reviewed By: phosek Differential Revision: https://reviews.llvm.org/D78373
-
Louis Dionne authored
It doesn't appear to be needed anymore with the Clang on our build bots.
-
Siva Chandra Reddy authored
Reviewers: phosek Differential Revision: https://reviews.llvm.org/D79725
-
Louis Dionne authored
We already set it using -rpath when linking test executables, and using DYLD_LIBRARY_PATH causes problems when running other commands that shouldn't run against the just-built libc++ (e.g. `ls` in a ShTest). rdar://63241847
-
Siva Chandra Reddy authored
A new utils library named 'fputil' is added. This library is used in math tests and the MPFR wrapper. The math implementations will be modified to use this library in a later round. Reviewers: phosek Differential Revision: https://reviews.llvm.org/D79724
-
Fangrui Song authored
Announced on https://lists.llvm.org/pipermail/llvm-dev/2020-May/141416.html Similar to D79371, but for `multiclass B` (convenience helper for defining --foo and --no-foo) Some changed options are also used by gold, but I haven't seen their one-dash use cases outside of lld's testsuite.
-
aartbik authored
Summary: First, compact implementation of lowering to LLVM IR. A bit more challenging than the constant mask due to the dynamic indices, of course. I like to hear if there are more efficient ways of doing this in LLVM, but this for now at least gives us a functional reference implementation. Reviewers: nicolasvasilache, ftynse, bkramer, reidtatge, andydavis1, mehdi_amini Reviewed By: nicolasvasilache Subscribers: mehdi_amini, rriddle, jpienaar, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, stephenneuendorffer, Joonsoo, grosul1, frgossen, Kayjukh, jurahul, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D79954
-
Sourabh Singh Tomar authored
This fixes bot failure seen in http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/7378 by adding `REQUIRES: x86_64-linux` to the test case
-
Louis Dionne authored
Since we're using the new testing format, DYLD_LIBRARY_PATH is not passed to the compiler -- it's only passed to the programs we run as an argument to the %{exec} substitution. -
Thomas Lively authored
Summary: Move instructions that have recently been implemented in V8 from the `unimplemented-simd128` target feature to the `simd128` target feature. The updated instructions match the update at https://github.com/WebAssembly/simd/pull/223. Reviewers: aheejin Subscribers: dschuff, sbc100, jgravelle-google, hiraditya, sunfish, cfe-commits, llvm-commits Tags: #clang, #llvm Differential Revision: https://reviews.llvm.org/D79973
-
Nicolas Vasilache authored
DimOp folding is using bare accesses to underlying SubViewOp operands. This is generally incorrect and is fixed in this revision. Differential Revision: https://reviews.llvm.org/D80017
-
Wouter van Oortmerssen authored
BuildMI requires this debug loc to be from the same sub program as the variable metadata passed in. Differential Revision: https://reviews.llvm.org/D80019
-
Sourabh Singh Tomar authored
This fixes bot failure seen in http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/7378 by adding `REQUIRES: x86_64-linux` to the test case
-
Nikita Popov authored
The "null-pointer-is-valid" attribute needs to be checked by many pointer-related combines. To make the check more efficient, convert it from a string into an enum attribute. In the future, this attribute may be replaced with data layout properties. Differential Revision: https://reviews.llvm.org/D78862
-
Stephen Neuendorffer authored
It is possible for optimizations to create SSA code which violates the dominance property in unreachable blocks. Equivalently, dominance computed using normal mechanisms is undefined in unreachable blocks. See discussion here: https://llvm.discourse.group/t/rfc-allowing-dialects-to-relax-the-ssa-dominance-condition/833/51 This patch only checks the dominance condition inside blocks which are reachable from the the entry block of their region. Note that the dominance conditions of regions contained in an unreachable block are still checked. Differential Revision: https://reviews.llvm.org/D79922
-
Simon Pilgrim authored
Avoid repeated isa<> and cast<> by just performing a dyn_cast<ConstantSDNode>
-
Jay Foad authored
Remove Use::setPrev. It provided no value because it had the same accessibility as the underlying field Prev, and there was no corresponding setNext anyway. Simplify Use::removeFromList.
-
Sanjay Patel authored
This broke when we started canonicalizing more code to funnel shift. See D79718 and D79827 for related test/transforms.
-
Louis Dionne authored
This is already handled by setting cxx_runtime_root instead -- I don't see a reason to have two ways of setting the runtime path of the library we're running against.
-