1. Aug 05, 2020
  2. Aug 04, 2020
    • chick's avatar
      Trial PR for using scalafmt · 8fd98d52
      chick authored
      - enables sbt plugin for scalafmt in sbt
      - adds travis test requiring scalafmt for PR
      - formats everything in src/
      - formats build.sbt
      8fd98d52
  3. Aug 02, 2020
  4. Aug 01, 2020
    • Kevin Laeufer's avatar
    • Jack Koenig's avatar
      Avoid repeated inlining in FlattenRegUpdate (#1727) · 17279da1
      Jack Koenig authored
      * Avoid repeated inlining in FlattenRegUpdate
      
      When-else structure can lead to the same complex mux structure being
      the default on several branches in register update logic. When these are
      inlined, it can lead to artifical unreachable branches that show up as
      coverage holes in coverage of the emitted Verilog. This commit changes
      the inlining logic to prevent inlining any reference expression that
      shows up multiple times because this is a common indicator of the
      problematic case.
      
      * Add tests for improved register update logic emission
      
      * Improve FlattenRegUpdate comment and add more tests
      
      * [skip formal checks] ICache equivalence check verified locally
      17279da1
    • Kevin Laeufer's avatar
      CircuitGraph: remove fields from public API (#1813) · 31132333
      Kevin Laeufer authored
      They are never used outside of the class
      not even in tests.
      31132333
    • Jiuyang Liu's avatar
      [WIP] Implement CircuitGraph and IRLookup to firrtl.analyses (#1603) · f22652a3
      Jiuyang Liu authored
      
      
      * WIP Commit
      
      * Add EdgeDataDiGraph with views to amortize graph construction
      
      * WIP, got basic structure, need tests to pipeclean
      
      * First tests pass. Need more.
      
      * Tests pass, more need to be written
      
      * More tests pass! Things should work, except for memories
      
      * Added clearPrev to fix digraph uses where caching prev breaks
      
      * Removed old Component. Documented IRLookup
      
      * Added comments. Make prev arg to getEdges
      
      * WIP: Refactoring for CircuitGraph
      
      * Refactored into CircuitGraph. Can do topological module analysis
      
      * Removed old versions
      
      * Added support for memories
      
      * Added cached test
      
      * More stufffff
      
      * Added implicit caching of connectivity
      
      * Added tests for IRLookup, and others
      
      * Many major changes.
      
      Replaced CircuitGraph as ConnectionGraph
      Added CircuitGraph to be top-level user-facing object
      ConnectionGraph now automatically shortcuts getEdges
      ConnectionGraph overwrites BFS as PriorityBFS
      Added leafModule to Target
      Added lookup by kind to IRLookup
      Added more tests
      
      * Reordered stuff in ConnectionGraph
      
      * Made path work with deep hierarchies. Added PML for IllegalClockCrossings
      
      * Made pathsInDAG work with current shortcut semantics
      
      * Bugfix: check pathless targets when shortcutting paths
      
      * Added documentation/licenses
      
      * Removed UnnamedToken and related functionality
      
      * Added documentation of ConnectionGraph
      
      * Added back topo, needed for correct solving of intermediate modules
      
      * Bugfix. Cache intermediate clockSources from same BFS with same root, but not BFS with different root
      
      * Added literal/invalid clock source, and unknown top for getclocksource
      
      * Bugfix for clocks in bundles
      
      * Add CompleteTargetSerializer and test
      
      * remove ClockFinder, be able to compile.
      
      * test is able to compile, but need to fix.
      
      * public and abstract DiGraph, remove DiGraphLike.
      
      * revert some DiGraph code, ConnectionGraphSpec passed.
      
      * CircuitGraphSpec passed.
      
      * minimize diff between master
      
      * codes clean up
      
      * override linearize and revert DiGraph
      
      * keep DiGraph unchanged.
      
      * make ci happy again.
      
      * codes clean up.
      
      * bug fix for rebase
      
      * remove wir
      
      * make scaladoc happy again.
      
      * update for review.
      
      * add some documentation.
      
      * remove tag
      
      * wip IRLookup
      
      * code clean up and add some doucmentations.
      
      * IRLookup cache with ModuleTarget guarded.
      
      * make unidoc and 2.13 happy
      
      Co-authored-by: default avatarAdam Izraelevitz <azidar@gmail.com>
      Co-authored-by: default avatarAlbert Magyar <albert.magyar@gmail.com>
      Co-authored-by: default avatarJack Koenig <koenig@sifive.com>
      f22652a3
  5. Jul 31, 2020
  6. Jul 30, 2020
  7. Jul 29, 2020
  8. Jul 28, 2020
  9. Jul 27, 2020
  10. Jul 25, 2020
    • Schuyler Eldridge's avatar
      Integrate new transforms with firrtl.stage.Forms (#1754) · d4e1a466
      Schuyler Eldridge authored
      
      
      Move new transforms, recently added, into existing or new sets of
      transforms (defined in firrtl.stage.Forms).
      
      One transform is a mandatory low FIRRTL optimization:
      
        - firrtl.transforms.LegalizeAndReductionsTransform
      
      Previously, this was included as a prerequisite of all Verilog
      emitters (minimum, normal, and SystemVerilog).
      
      Two transforms associated with converting and removing the new
      verification statements are moved into a new set of transforms,
      AssertsRemoved:
      
        - firrtl.transforms.formal.ConvertAsserts
        - firrtl.transforms.formal.RemoveVerificationStatements
      
      Previously, these transforms were directly added as prerequisites to
      the minimum Verilog and normal Verilog emitter, but not the
      SystemVerilog emitter.
      
      The designation of inputForm=LowForm for legacy, custom transforms is
      updated to include assertion removal transforms as part of their
      optionalPrerequisites. This has the effect of continuing to cause
      inputForm=LowForm transforms to run as late as possible (right before
      the low FIRRTL, minimum Verilog, Verilog, or SystemVeriog emitter).
      
      Tests are updated to reflect the new order in both CustomTransformSpec
      and LoweringCompilersSpec.
      
      Signed-off-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>
      
      Co-authored-by: default avatarmergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
      d4e1a466
    • Albert Chen's avatar
      Fix sign extension issue in Emitter (#1785) · b24b9a01
      Albert Chen authored
      * add sign-extend const-prop test
      
      * Emitter: don't wrap Neg operand in concat
      b24b9a01