Co-authored-by: Jack Koenig <koenig@sifive.com>

Implement a SyncReadMem wrapper with explicit read, write, and read/write ports (backport #3228) (#3361)

* Implement a SyncReadMem wrapper with explicit read, write, and readwrite ports (#3228)

Co-authored-by: Jiuyang Liu <liu@jiuyang.me>
Co-authored-by: Jack Koenig <koenig@sifive.com>
(cherry picked from commit 8851faed

)

* Delete typeName def

---------

Co-authored-by: Jared Barocsi <82000041+jared-barocsi@users.noreply.github.com>
Co-authored-by: Jared Barocsi <jared.barocsi@sifive.com>

(cherry picked from commit b83f3695

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit 308eb6a4

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

This enables Chisel users to use these newer Scala versions.

(cherry picked from commit b22c3ba2

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit e20a0380

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

Don't emit implicit clock warnings for `SyncReadMem.readWrite` when explicit clocks are used (backport #3313) (#3315)

* Don't emit implicit clock warnings when an explicit clock is used (#3313)

(cherry picked from commit 9e392013

)

# Conflicts:
#	core/src/main/scala/chisel3/Mem.scala

* Resolve backport conflicts

---------

Co-authored-by: Jared Barocsi <82000041+jared-barocsi@users.noreply.github.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>

* Optimize BitPat equals, overlap, and cover (#3285)

(cherry picked from commit f590ac9f

)

* Fix binary compatibility issue

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>

This does not seem to be required by Scala, but it is required by newer
versions of SemanticDB (and thus to use Scala Metals).

(cherry picked from commit 08369ef8

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit b542b6ab

)

Co-authored-by: Sihao Liu <sihao@cs.ucla.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Change what DataView allows in its type checking to enable Reset to be
viewed as either a UInt<1> or an AsyncReset.  This enables more flexible
DataViews which match already allowable Chisel and FIRRTL connection
semantics.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
(cherry picked from commit 44ce96cf

)

Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>

* Add new workflow to fixup backports for release notes (#3252)

The Mergify-generated backports do not currently include the information
needed by the release notes generation automation. This new workflow
will copy such information over to backport PRs.

(cherry picked from commit 86ccd1b2)

* Fix backport-fixup for labels with spaces (#3255)

(cherry picked from commit 8f7e7e68

)

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit 7b57e591

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit bc4d8f9a

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

* Implement read-write memory accessors for SyncReadMem (#3190)

Adds new APIs to generate explicit read-write (rdwr) ports for a SyncReadMem, and all masked or clocked variants.
---------

Co-authored-by: Megan Wachs <megan@sifive.com>
(cherry picked from commit 1e6f2b4e

)

* Add CompileOptions to SyncReadMem.readWrite methods

---------

Co-authored-by: Jared Barocsi <82000041+jared-barocsi@users.noreply.github.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Change many tests from simulation-based to checking the CHIRRTL.
* Move tests that were hard to convert to new VecIntegrationSpec in
  integration-tests

(cherry picked from commit 6b81f44c

)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

(cherry picked from commit 8ca8b2e1

)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Read previousVersions for bincompat checking from a file (#3202)

This makes it much easier to automate checking new versions as they are
released.

---------

Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
(cherry picked from commit 2c6028b0

)

# Conflicts:
#	build.sbt

* Enable binary compatibility checking against 3.6.0

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>

This adds a new Chisel template for using Chisel with Scala CLI, and
adds some automation for uploading versions of this template on tagged
releases (or workflow dispatch).

(cherry picked from commit 20246185

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit 4b891ecf

)

Co-authored-by: Adam Izraelevitz <adam.izraelevitz@sifive.com>

* Report firtool version when firtool invocation errors (#3174)

* the firtool version is now included in the BuildInfo
* firtool now must be on the path when publishing, but is not required
  for building or testing
* FirtoolNonZeroExitCode now no longer includes a stack trace

(cherry picked from commit 06b569da

)

# Conflicts:
#	build.sbt

* Resolve backport conflicts

* [CI] Install firtool in the publish step (#3176)

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>

* Fix naming for RHS of named unapply expressions (#3163)

Previously, the naming plugin would not recurse for the RHS of an
unapply, meaning that vals declared in blocks that ultimately return
some result that is unapplied into some named Data would not be named.

Also, audit and improve the naming mdocs.

(cherry picked from commit 262caa73

)

# Conflicts:
#	docs/src/cookbooks/naming.md

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit a6525268

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

Co-authored-by: Jack Koenig <koenig@sifive.com>
(cherry picked from commit f3d0f22d

)

Co-authored-by: Aditya Naik <91489422+adkian-sifive@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Detect bound hardware when processing record elements (#3037)

Use new private Record._elements to validate Record elements. This
allows us to check invariants earlier than on cloning or binding.

(cherry picked from commit a8515661

)

# Conflicts:
#	core/src/main/scala/chisel3/internal/BiConnect.scala
#	core/src/main/scala/chisel3/internal/MonoConnect.scala

* Fix backport conflicts

---------

Co-authored-by: Aditya Naik <91489422+adkian-sifive@users.noreply.github.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit 29562386

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit 068eb8f7

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

* Add SBT aliases for formatting including SBT files (#3125)

Also run formatting on SBT files.

(cherry picked from commit 3da4113e

)

# Conflicts:
#	build.sbt
#	project/plugins.sbt

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit ac10d5b8

)

Co-authored-by: Sean Jensen-Grey <128454+seanjensengrey@users.noreply.github.com>

Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit baed66d4

)

Co-authored-by: jensengrey <46599294+jensengrey@users.noreply.github.com>

It seems that deprecations on methods that are macro expanded away do
not actually trigger a deprecation warning. Instead, we will just accept
no source locator on the deprecated API (no released version of Chisel
has the source locator).

(cherry picked from commit 847343a3

)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Deprecate ImplicitInvalidate

* Suppress warnings from ImplicitInvalidate

---------

Co-authored-by: Adam Izraelevitz <adam.izraelevitz@sifive.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Remove LegacyModule and LegacyBlackBox (#3058)

(cherry picked from commit 9b2e288c

)

# Conflicts:
#	core/src/main/scala/chisel3/internal/package.scala

* Change removal to deprecation

---------

Co-authored-by: Adam Izraelevitz <adam.izraelevitz@sifive.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Undo move of Cat from chisel3.util to chisel3 (#3110)

It is a very painful change for users with marginal benefit. We plan to
change the package to chisel in the not-so-distant future--that's a much
better opportunity to make this change.

(cherry picked from commit 036b1e90

)

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>

* overload MuxLookup.apply for EnumType
* remove MuxLookup.fromEnum
* add source locators to MuxLookup.apply using macros

(cherry picked from commit dcecabb6

)

Co-authored-by: Albert Chen <40366337+albertchen-sifive@users.noreply.github.com>

* Remove deprecated CIRCT Options (#3101)

* Make read-write inference on by default

Change CIRCT to turn on read-write inference by default.  This is
primarily done because this option was removed in:

  https://github.com/llvm/circt/commit/9620d656f8a59998cc38472a60f83bfdcb6a8549



Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>

* Remove IMCP disable option for CIRCT

Remove the ability to disable inter-module constant propagation (IMCP) when
running with CIRCT.  This option was removed in:

  https://github.com/llvm/circt/commit/9620d656f8a59998cc38472a60f83bfdcb6a8549



Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>

---------

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
(cherry picked from commit 3158c492

)

# Conflicts:
#	src/main/scala/circt/stage/phases/CIRCT.scala

* Resolve backport conflicts

---------

Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>

* Fix FIRRTL spec emission and bump to spec 1.2.0 (#3094)

* Emit FIRRTL spec version in Emitter
* Bump FIRRTL spec version to 1.2.0

(cherry picked from commit 1ef1fc4e

)

# Conflicts:
#	firrtl/src/main/scala/firrtl/ir/Serializer.scala
#	firrtl/src/test/scala/firrtlTests/ExtModuleTests.scala

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>

Also remove deploy_website job as we only want to deploy the website
from main.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit c246b28a

)

Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>