Skip to content
GitLab
  1. Dec 10, 2021
  3. Aug 31, 2021
  5. Aug 30, 2021
  7. Jul 10, 2021
    • mergify[bot]'s avatar
      Fix chisel3 <> for Bundles that contain compatibility Bundles (Take 2) (backport #2031) (#2033) · 0cbaf502
      mergify[bot] authored 
      * Fix chisel3 <> for Bundles that contain compatibility Bundles (Take 2) (#2031)

PR #2023 fixed a composition issue for chisel3 biconnects delegating to
FIRRTL partial connect when compatibility mode Bundles are elements of
chisel3 Bundles. It missed an important case though that caused
previously working code to break.

The bug is fixed by doing the automatic flipping for compatibility mode
Bundles that have "Input" as a direction in addition to those that are
"Flipped".

(cherry picked from commit 5183ef88

)

# Conflicts:
#	src/test/scala/chiselTests/CompatibilityInteroperabilitySpec.scala

* Resolve backport conflicts

Co-authored-by: default avatarJack Koenig <koenig@sifive.com>
      0cbaf502
  9. Jul 09, 2021
  11. Jun 30, 2021
    • mergify[bot]'s avatar
      Fix aop.Select behavior for CloneModuleAsRecord (backport #1993) (#1994) · 18ce22ba
      mergify[bot] authored 
      * Restore aop.Select behavior for CloneModuleAsRecord

(cherry picked from commit 0531cb53)

* Change behavior of aop.Select to not include CloneModuleAsRecord

Previously, CloneModuleAsRecord clones would result in the same
BaseModule object coming up multiple times when using APIs like
.instances, .collectDeep, and .getDeep. This was not the intended
behavior and can lead to very subtle bugs.

(cherry picked from commit 25a84b56

)

Co-authored-by: default avatarJack Koenig <koenig@sifive.com>
      18ce22ba
    • mergify[bot]'s avatar
      Fix CloneModuleAsRecord support for .toTarget (backport #1974) (#1985) · 081874e5
      mergify[bot] authored 
      * Fix CloneModuleAsRecord support for .toTarget

(cherry picked from commit d3e13ce2)

# Conflicts:
#	core/src/main/scala/chisel3/Module.scala
#	core/src/main/scala/chisel3/RawModule.scala
#	core/src/main/scala/chisel3/internal/Builder.scala
#	core/src/main/scala/chisel3/internal/firrtl/Converter.scala

* Set refs for ModuleClone and ClonePorts in less hacky way

(cherry picked from commit b87107ad

)

# Conflicts:
#	core/src/main/scala/chisel3/Module.scala
#	core/src/main/scala/chisel3/RawModule.scala

* Fixup for backport

* Resolve merge conflicts
* Fix semantic meaning change of Module -> MultiIOModule on master
* Waive bincompat errors that cannot impact Scala users

Co-authored-by: default avatarJack Koenig <koenig@sifive.com>
      081874e5
  13. May 26, 2021
  15. May 20, 2021
  17. Mar 30, 2021
  19. Mar 19, 2021
    • mergify[bot]'s avatar
      Don't toggle top.cpp clock and reset on same cycle (#1820) (#1822) · 1941679e
      mergify[bot] authored 
      

Change top.cpp to deassert reset one time unit before the clock asserts.
This avoids a Verilator simultation issue in top.cpp where the eval()
function is only called once per simultation loop.  If the clock and
reset are both changed and eval() is only called once, then any
combinational update due to a change in reset is not visible to the
sequential logic.  This avoids issues where the downstream compilation
utilities move synchronous reset logic outside of an always block that
describes a synchronous reset flip flop.

Reset now deasserts on time unit 10 and the clock ticks on time unit
11.

h/t @albert-magyar

Signed-off-by: default avatarSchuyler Eldridge <schuyler.eldridge@sifive.com>
(cherry picked from commit ac094a5e

)

Co-authored-by: default avatarSchuyler Eldridge <schuyler.eldridge@sifive.com>
      1941679e
  21. Feb 24, 2021
  23. Feb 06, 2021
  25. Feb 02, 2021
  27. Jan 27, 2021
  29. Jan 25, 2021
  31. Jan 12, 2021
    • mergify[bot]'s avatar
      Make `toTarget` fail if called on a Literal (or would otherwise not serialize... · e8b449ec
      mergify[bot] authored 
      Make `toTarget` fail if called on a Literal (or would otherwise not serialize properly) (bp #1714) (#1720)

* Make `toTarget` fail if called on a Literal (or would otherwise not serialize properly) (#1714)

* Add (failing) Test for Data toTarget calls

Add scaladoc and clean up test

* Builder: don't let .toTarget pass if it won't be able to deserialize properly later

* Update src/test/scala/chiselTests/ReferenceTargetSpec.scala

* Rename and simplify tests for literal toTarget

(cherry picked from commit b578aa5e

)

# Conflicts:
#	core/src/main/scala/chisel3/internal/Builder.scala

* fixup! Make `toTarget` fail if called on a Literal (or would otherwise not serialize properly) (#1714)

Co-authored-by: default avatarMegan Wachs <megan@sifive.com>
Co-authored-by: default avatarSchuyler Eldridge <schuyler.eldridge@sifive.com>
      e8b449ec
  33. Dec 18, 2020
  35. Dec 17, 2020
    • mergify[bot]'s avatar
      Switch to using Github Actions CI (bp #1690) (#1699) · 719b9016
      mergify[bot] authored 
      * Switch to using Github Actions CI (#1690)

MiMa binary compatibility checks are now run on master, but the
mimaPreviousArtifacts are empty which makes the check a no-op. This
helps keep both the build.sbt and CI more consistent between master and
stable branches.

.mergify.yml is also updated with mergify.sc from chisel-repo-tools
using the following configuration:

conditions:
  - status-success=all tests passed
branches:
  - 3.2.x
  - 3.3.x
  - 3.4.x
(cherry picked from commit 25a417f8

)

# Conflicts:
#	.mergify.yml
#	build.sbt
#	project/plugins.sbt

* Resolve merge conflicts

* Remove mdoc check from GithubActions

This test was added in 3.4

Co-authored-by: default avatarJack Koenig <koenig@sifive.com>
      719b9016
  37. Nov 11, 2020
  39. Oct 20, 2020
  41. Oct 10, 2020
  43. Sep 10, 2020
  45. Aug 07, 2020
  47. Jul 31, 2020
  49. Jul 29, 2020
  51. Jun 24, 2020
  53. Jun 23, 2020
  55. Jun 20, 2020
  57. Jun 09, 2020