Unverified Commit e14dc6d1 authored by mergify[bot]'s avatar mergify[bot] Committed by GitHub
Browse files

Dont wrap elaboration annotations (bp #1374) (#1378)



* Wrap elaboration in ChiselException

Signed-off-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>

squash! Wrap elaboration in ChiselException

(cherry picked from commit d67c4100

)

* Report trimmed stack trace of Builder cause

Changes the behavior of ChiselException stack trace trimming to use
either the first exception that includes a method from the Builder or
the outer exception.

Signed-off-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>
(cherry picked from commit 73974725

)

* Test nested ChiselException in ChiselMain

Adds two tests:

  1. Test that an internal requirement failure (a bare exception) inside
     a Builder is properly reported/trimmed by ChsielStage/ChiselMain
  2. Test that the full stack trace includes the ChiselException

Signed-off-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>
(cherry picked from commit 18520bf1

)

* Code style improvement

Co-authored-by: default avatarJack Koenig <koenig@sifive.com>
Signed-off-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>
(cherry picked from commit 30a0a5f9

)

* Safer generation of ChiselException.builderName

Change ChiselException.builderName to compute the name of Chisel's
internal Builder as opposed to hard-coding this with a string.

Signed-off-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>
(cherry picked from commit 969a56d6

)

* Add Scaladoc to ChiselException

Signed-off-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>
(cherry picked from commit 3171cdf8

)

Co-authored-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>
parent 063a23a2
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment