diff options
| author | Tomas Vanek <vanekt@fbl.cz> | 2019-12-20 23:56:08 +0100 |
|---|---|---|
| committer | Tomas Vanek <vanekt@fbl.cz> | 2020-03-07 15:30:05 +0000 |
| commit | a2e822834df52efef5e1bbcb91a6eb1afbf102db (patch) | |
| tree | 0e5caf3d1daa7dfeb6cabc7f3163d6dd5bbc73f9 /src/jtag/core.c | |
| parent | 4e981bc27c36e696dc8ace3ab4bab534564770c1 (diff) | |
| download | riscv-openocd-a2e822834df52efef5e1bbcb91a6eb1afbf102db.zip riscv-openocd-a2e822834df52efef5e1bbcb91a6eb1afbf102db.tar.gz riscv-openocd-a2e822834df52efef5e1bbcb91a6eb1afbf102db.tar.bz2 | |
helper/binarybuffer: fix clang static analyzer warnings
Writing bits to an uninitialized buffer generated false warnings.
Zero buffers before setting them by buf_set_u32|64()
(do it only if bit-by-bit copy loop is used,
zeroed buffer is not necessary if a fast path write is used)
Change-Id: I2f7f8ddb45b0cbd08d3e249534fc51f4b5cc6694
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: http://openocd.zylin.com/5383
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Diffstat (limited to 'src/jtag/core.c')
| -rw-r--r-- | src/jtag/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/jtag/core.c b/src/jtag/core.c index 1d59712..c5011e5 100644 --- a/src/jtag/core.c +++ b/src/jtag/core.c @@ -1233,7 +1233,7 @@ static int jtag_examine_chain(void) /* Add room for end-of-chain marker. */ max_taps++; - uint8_t *idcode_buffer = malloc(max_taps * 4); + uint8_t *idcode_buffer = calloc(4, max_taps); if (idcode_buffer == NULL) return ERROR_JTAG_INIT_FAILED; |