diff options
| author | Marc Schink <openocd-dev@marcschink.de> | 2016-05-22 19:44:27 +0200 |
|---|---|---|
| committer | Andreas Fritiofson <andreas.fritiofson@gmail.com> | 2016-10-17 09:28:05 +0100 |
| commit | 674141e8a7a6413cb803d90c2a20150260015f81 (patch) | |
| tree | 62296ce0bfefecce10134718de8c4a81c5cb50ef /src/rtos/rtos.c | |
| parent | 10aeff925936a43e873acfd0068b1eea03781051 (diff) | |
| download | riscv-openocd-674141e8a7a6413cb803d90c2a20150260015f81.zip riscv-openocd-674141e8a7a6413cb803d90c2a20150260015f81.tar.gz riscv-openocd-674141e8a7a6413cb803d90c2a20150260015f81.tar.bz2 | |
helper: Make unhexify() robust on invalid data
The current implementation is not suitable for user provided data
because it does not detect invalid inputs in many cases. For example,
the string "aa0xbb" is successfully converted to the 3 bytes: 0xaa,
0x00 and 0xbb. An other example is "aabi" which is successfully
converted to the 2 bytes: 0xaa and 0x0b. Both are obviously incorrect.
Make unhexify() robust on invalid data and use more appropriate data
types for its parameters. Also, add a small documentation for the
function.
Change-Id: Idb799beb86fc608b066c8a76365021ed44c7f890
Signed-off-by: Marc Schink <openocd-dev@marcschink.de>
Reviewed-on: http://openocd.zylin.com/3792
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Diffstat (limited to 'src/rtos/rtos.c')
| -rw-r--r-- | src/rtos/rtos.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/rtos/rtos.c b/src/rtos/rtos.c index 4c99ad2..448c49c 100644 --- a/src/rtos/rtos.c +++ b/src/rtos/rtos.c @@ -213,7 +213,7 @@ int rtos_qsymbol(struct connection *connection, char const *packet, int packet_s goto done; /* Decode any symbol name in the packet*/ - int len = unhexify(cur_sym, strchr(packet + 8, ':') + 1, strlen(strchr(packet + 8, ':') + 1)); + size_t len = unhexify((uint8_t *)cur_sym, strchr(packet + 8, ':') + 1, strlen(strchr(packet + 8, ':') + 1)); cur_sym[len] = 0; if ((strcmp(packet, "qSymbol::") != 0) && /* GDB is not offering symbol lookup for the first time */ |