diff options
| author | Antonio Borneo <borneo.antonio@gmail.com> | 2022-06-01 19:47:48 +0200 |
|---|---|---|
| committer | Antonio Borneo <borneo.antonio@gmail.com> | 2022-06-10 21:54:40 +0000 |
| commit | 54f0cab18efadd7c132021228a3ef04ae1fea3ea (patch) | |
| tree | 51d471b2f47c464f43b4b55cfd0bace04d5ac419 /src/jtag | |
| parent | 95135b39ccc3d8cec79053a71d0289e7fdeeafe9 (diff) | |
| download | riscv-openocd-54f0cab18efadd7c132021228a3ef04ae1fea3ea.zip riscv-openocd-54f0cab18efadd7c132021228a3ef04ae1fea3ea.tar.gz riscv-openocd-54f0cab18efadd7c132021228a3ef04ae1fea3ea.tar.bz2 | |
drivers/bitbang: silence scan-build warning
The array is partially initialized with buf_set_u32(,5,32,), then
the rest of the array is read from SWD.
But scan-build report the array to have garbage content after the
initialization, due to the offset of 5 bit that only inits part of
the first byte.
Silence the false positive from scan-build by initializing the
array.
Change-Id: Ic38d50280f67939e3ec5fa05741f66d5f993f8c2
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7013
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Diffstat (limited to 'src/jtag')
| -rw-r--r-- | src/jtag/drivers/bitbang.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/jtag/drivers/bitbang.c b/src/jtag/drivers/bitbang.c index 898d6d3..78dcb29 100644 --- a/src/jtag/drivers/bitbang.c +++ b/src/jtag/drivers/bitbang.c @@ -532,8 +532,9 @@ static void bitbang_swd_write_reg(uint8_t cmd, uint32_t value, uint32_t ap_delay /* Devices do not reply to DP_TARGETSEL write cmd, ignore received ack */ bool check_ack = swd_cmd_returns_ack(cmd); + /* init the array to silence scan-build */ + uint8_t trn_ack_data_parity_trn[DIV_ROUND_UP(4 + 3 + 32 + 1 + 4, 8)] = {0}; for (;;) { - uint8_t trn_ack_data_parity_trn[DIV_ROUND_UP(4 + 3 + 32 + 1 + 4, 8)]; buf_set_u32(trn_ack_data_parity_trn, 1 + 3 + 1, 32, value); buf_set_u32(trn_ack_data_parity_trn, 1 + 3 + 1 + 32, 1, parity_u32(value)); |