diff options
author | Tomas Vanek <vanekt@fbl.cz> | 2018-11-15 12:19:25 +0100 |
---|---|---|
committer | Tomas Vanek <vanekt@fbl.cz> | 2018-11-26 09:31:35 +0000 |
commit | 9542cb7c3d9f4b66d2df3d8412a73d008077ab86 (patch) | |
tree | 5bdcd193b5b2a2e06d5e2e03fbf85dca53eddbf8 /src/flash/nor/cfi.c | |
parent | ff555afc02d50ca57fc6e71787d34a8e985cf115 (diff) | |
download | riscv-openocd-9542cb7c3d9f4b66d2df3d8412a73d008077ab86.zip riscv-openocd-9542cb7c3d9f4b66d2df3d8412a73d008077ab86.tar.gz riscv-openocd-9542cb7c3d9f4b66d2df3d8412a73d008077ab86.tar.bz2 |
flash/nor: consolidate flash protect/protect_check
Make flash_driver methods protect() and protect_check()
optional.
Remove dummy definitions of these methods from the drivers
which do not implement protection handling.
Some drivers did not define protect method. It raised segfault
before this change and now it is handled properly.
Lot of drivers returned ERROR_OK from dummy protect()
- now flash_driver_protect() returns an error if not handled by the driver.
Change-Id: I2d4a0da316bf03c6379791b1b1c6198fbf22e66c
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: http://openocd.zylin.com/4765
Tested-by: jenkins
Reviewed-by: Andreas Bolsch <hyphen0break@gmail.com>
Reviewed-by: Christopher Head <chead@zaber.com>
Diffstat (limited to 'src/flash/nor/cfi.c')
-rw-r--r-- | src/flash/nor/cfi.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/flash/nor/cfi.c b/src/flash/nor/cfi.c index 0ae72d4..a2db50f 100644 --- a/src/flash/nor/cfi.c +++ b/src/flash/nor/cfi.c @@ -1098,11 +1098,6 @@ static int cfi_protect(struct flash_bank *bank, int set, int first, int last) return ERROR_TARGET_NOT_HALTED; } - if ((first < 0) || (last < first) || (last >= bank->num_sectors)) { - LOG_ERROR("Invalid sector range"); - return ERROR_FLASH_SECTOR_INVALID; - } - if (cfi_info->qry[0] != 'Q') return ERROR_FLASH_BANK_NOT_PROBED; |