diff options
| author | Tarek BOCHKATI <tarek.bouchkati@gmail.com> | 2021-08-11 01:14:21 +0100 |
|---|---|---|
| committer | Antonio Borneo <borneo.antonio@gmail.com> | 2021-09-18 15:27:46 +0000 |
| commit | 050fcb176071cadc7142c4d9acd3f5a9e67d3ac6 (patch) | |
| tree | a8f6b830a5bccc51f95ff4f08aa6cf2786968c41 | |
| parent | 1efd12a6de0787097d08807809643905b7d03d68 (diff) | |
| download | riscv-openocd-050fcb176071cadc7142c4d9acd3f5a9e67d3ac6.zip riscv-openocd-050fcb176071cadc7142c4d9acd3f5a9e67d3ac6.tar.gz riscv-openocd-050fcb176071cadc7142c4d9acd3f5a9e67d3ac6.tar.bz2 | |
helper/command: fix echo return values
the echo command is managed through command handler and not jim_handler
to be consistent rename the handler from jim_echo to handle_echo
and update the return values
Fixes: 4747af362de0 (JIM: document "echo" command)
Change-Id: I5ae87ea802d8430b573fb83daa6b35490b5d5775
Signed-off-by: Tarek BOCHKATI <tarek.bouchkati@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/6549
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
| -rw-r--r-- | src/helper/command.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/src/helper/command.c b/src/helper/command.c index e5529d9..7c29f73 100644 --- a/src/helper/command.c +++ b/src/helper/command.c @@ -718,16 +718,18 @@ static int jim_find(Jim_Interp *interp, int argc, Jim_Obj *const *argv) return JIM_OK; } -COMMAND_HANDLER(jim_echo) +COMMAND_HANDLER(handle_echo) { if (CMD_ARGC == 2 && !strcmp(CMD_ARGV[0], "-n")) { LOG_USER_N("%s", CMD_ARGV[1]); - return JIM_OK; + return ERROR_OK; } + if (CMD_ARGC != 1) - return JIM_ERR; + return ERROR_FAIL; + LOG_USER("%s", CMD_ARGV[0]); - return JIM_OK; + return ERROR_OK; } /* Capture progress output and return as tcl return value. If the @@ -1219,7 +1221,7 @@ static const struct command_registration command_builtin_handlers[] = { }, { .name = "echo", - .handler = jim_echo, + .handler = handle_echo, .mode = COMMAND_ANY, .help = "Logs a message at \"user\" priority. " "Option \"-n\" suppresses trailing newline", |