diff options
| author | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-06-27 15:18:02 +1000 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-06-27 15:19:07 +1000 |
| commit | c4d48a3a6ac7cab879d39f4af1ac60dec6f19e07 (patch) | |
| tree | c1ac739e8b70685aa96e7127f18d2782623624e1 | |
| parent | 6b4acd606dd5309682d1a5e136364533d2a1a2f2 (diff) | |
| download | skiboot-c4d48a3a6ac7cab879d39f4af1ac60dec6f19e07.zip skiboot-c4d48a3a6ac7cab879d39f4af1ac60dec6f19e07.tar.gz skiboot-c4d48a3a6ac7cab879d39f4af1ac60dec6f19e07.tar.bz2 | |
hdata/memory.c: add FWTS annotation for invalid timebase size
Requires generate-fwts-olog fixup for regex generation
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
| -rw-r--r-- | hdata/memory.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/hdata/memory.c b/hdata/memory.c index ca21da8..a8b9955 100644 --- a/hdata/memory.c +++ b/hdata/memory.c @@ -214,6 +214,12 @@ static void add_bus_freq_to_ram_area(struct dt_node *ram_node, u32 chip_id) timebase = HDIF_get_idata(pcia, SPPCIA_IDATA_TIMEBASE, &size); if (!timebase || size < sizeof(*timebase)) { + /** + * @fwts-label HDATBadTimebaseSize + * @fwts-advice HDAT described an invalid size for timebase, + * which means there's a disagreement between HDAT and OPAL. + * This is most certainly a firmware bug. + */ prlog(PR_ERR, "HDAT: Bad timebase size %u @ %p\n", size, timebase); return; |