From c4d48a3a6ac7cab879d39f4af1ac60dec6f19e07 Mon Sep 17 00:00:00 2001 From: Stewart Smith Date: Mon, 27 Jun 2016 15:18:02 +1000 Subject: hdata/memory.c: add FWTS annotation for invalid timebase size Requires generate-fwts-olog fixup for regex generation Signed-off-by: Stewart Smith --- hdata/memory.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hdata/memory.c b/hdata/memory.c index ca21da8..a8b9955 100644 --- a/hdata/memory.c +++ b/hdata/memory.c @@ -214,6 +214,12 @@ static void add_bus_freq_to_ram_area(struct dt_node *ram_node, u32 chip_id) timebase = HDIF_get_idata(pcia, SPPCIA_IDATA_TIMEBASE, &size); if (!timebase || size < sizeof(*timebase)) { + /** + * @fwts-label HDATBadTimebaseSize + * @fwts-advice HDAT described an invalid size for timebase, + * which means there's a disagreement between HDAT and OPAL. + * This is most certainly a firmware bug. + */ prlog(PR_ERR, "HDAT: Bad timebase size %u @ %p\n", size, timebase); return; -- cgit v1.1