diff options
| author | Eli Schwartz <eschwartz@archlinux.org> | 2022-09-20 23:59:35 -0400 |
|---|---|---|
| committer | Xavier Claessens <xclaesse@gmail.com> | 2022-09-22 18:15:25 -0400 |
| commit | 332968da1b1e0708df6fd7aa1977015710d7dc7c (patch) | |
| tree | 9e0fb2b015bb2390887e75a47b76285bbb3417d5 | |
| parent | 0d354588cab00cb37f8f8fb81b1af43b77754a08 (diff) | |
| download | meson-332968da1b1e0708df6fd7aa1977015710d7dc7c.zip meson-332968da1b1e0708df6fd7aa1977015710d7dc7c.tar.gz meson-332968da1b1e0708df6fd7aa1977015710d7dc7c.tar.bz2 | |
use simpler subprocess.run interface instead of manual Popen
This code dates back to 2012 and probably has no specific reason...
| -rw-r--r-- | mesonbuild/compilers/mixins/clike.py | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/mesonbuild/compilers/mixins/clike.py b/mesonbuild/compilers/mixins/clike.py index 9bc07d0..d1a3ba2 100644 --- a/mesonbuild/compilers/mixins/clike.py +++ b/mesonbuild/compilers/mixins/clike.py @@ -332,10 +332,9 @@ class CLikeCompiler(Compiler): cmdlist = [binary_name] mlog.debug('Running test binary command: ', mesonlib.join_args(cmdlist)) try: - pe = subprocess.Popen(cmdlist) + pe = subprocess.run(cmdlist) except Exception as e: raise mesonlib.EnvironmentException(f'Could not invoke sanity test executable: {e!s}.') - pe.wait() if pe.returncode != 0: raise mesonlib.EnvironmentException(f'Executables created by {self.language} compiler {self.name_string()} are not runnable.') |