diff options
| author | Eli Schwartz <eschwartz@archlinux.org> | 2022-09-20 23:53:36 -0400 |
|---|---|---|
| committer | Xavier Claessens <xclaesse@gmail.com> | 2022-09-22 18:15:25 -0400 |
| commit | 0d354588cab00cb37f8f8fb81b1af43b77754a08 (patch) | |
| tree | 9e2b184a4741df60bfef91a54a143fbfbde7ff76 | |
| parent | 29ac7dd0883454e6d5f26a0d666f13a9faf98238 (diff) | |
| download | meson-0d354588cab00cb37f8f8fb81b1af43b77754a08.zip meson-0d354588cab00cb37f8f8fb81b1af43b77754a08.tar.gz meson-0d354588cab00cb37f8f8fb81b1af43b77754a08.tar.bz2 | |
compilers: make sanity checks log commands using join_args
It is more correct to join commands with a command joiner than a
whitespace joiner.
| -rw-r--r-- | mesonbuild/compilers/mixins/clike.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/mesonbuild/compilers/mixins/clike.py b/mesonbuild/compilers/mixins/clike.py index b1792eb..9bc07d0 100644 --- a/mesonbuild/compilers/mixins/clike.py +++ b/mesonbuild/compilers/mixins/clike.py @@ -285,7 +285,7 @@ class CLikeCompiler(Compiler): def _sanity_check_impl(self, work_dir: str, environment: 'Environment', sname: str, code: str) -> None: - mlog.debug('Sanity testing ' + self.get_display_language() + ' compiler:', ' '.join(self.exelist)) + mlog.debug('Sanity testing ' + self.get_display_language() + ' compiler:', mesonlib.join_args(self.exelist)) mlog.debug(f'Is cross compiler: {self.is_cross!s}.') source_name = os.path.join(work_dir, sname) @@ -314,7 +314,7 @@ class CLikeCompiler(Compiler): # after which all further arguments will be passed directly to the linker cmdlist = self.exelist + [sname] + self.get_output_args(binname) + extra_flags pc, stdo, stde = mesonlib.Popen_safe(cmdlist, cwd=work_dir) - mlog.debug('Sanity check compiler command line:', ' '.join(cmdlist)) + mlog.debug('Sanity check compiler command line:', mesonlib.join_args(cmdlist)) mlog.debug('Sanity check compile stdout:') mlog.debug(stdo) mlog.debug('-----\nSanity check compile stderr:') @@ -330,7 +330,7 @@ class CLikeCompiler(Compiler): cmdlist = self.exe_wrapper.get_command() + [binary_name] else: cmdlist = [binary_name] - mlog.debug('Running test binary command: ' + ' '.join(cmdlist)) + mlog.debug('Running test binary command: ', mesonlib.join_args(cmdlist)) try: pe = subprocess.Popen(cmdlist) except Exception as e: |