diff options
| author | Thomas Huth <thuth@redhat.com> | 2020-06-30 09:55:20 +0200 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2020-09-01 08:42:27 +0200 |
| commit | bd7b4e1fe67561fb8b67c0617b7ea4febd1297a0 (patch) | |
| tree | b7b6f3e51fd1452fc03202f9f6a11ff953a342a7 | |
| parent | 8ff1e46eaac793112af0356f979e075566e34534 (diff) | |
| download | qemu-bd7b4e1fe67561fb8b67c0617b7ea4febd1297a0.zip qemu-bd7b4e1fe67561fb8b67c0617b7ea4febd1297a0.tar.gz qemu-bd7b4e1fe67561fb8b67c0617b7ea4febd1297a0.tar.bz2 | |
hw/net/can: Add missing fallthrough statements
Add fallthrough annotations to be able to compile the code without
warnings when using -Wimplicit-fallthrough in our CFLAGS. Looking
at the code, it seems like the fallthrough is indeed intended here,
so the comments should be appropriate.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Message-Id: <20200630075520.29825-1-thuth@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
| -rw-r--r-- | hw/net/can/can_sja1000.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/hw/net/can/can_sja1000.c b/hw/net/can/can_sja1000.c index ea915a0..2999329 100644 --- a/hw/net/can/can_sja1000.c +++ b/hw/net/can/can_sja1000.c @@ -523,6 +523,7 @@ void can_sja_mem_write(CanSJA1000State *s, hwaddr addr, uint64_t val, break; case 16: /* RX frame information addr16-28. */ s->status_pel |= (1 << 5); /* Set transmit status. */ + /* fallthrough */ case 17 ... 28: if (s->mode & 0x01) { /* Reset mode */ if (addr < 24) { @@ -620,6 +621,7 @@ void can_sja_mem_write(CanSJA1000State *s, hwaddr addr, uint64_t val, break; case 10: s->status_bas |= (1 << 5); /* Set transmit status. */ + /* fallthrough */ case 11 ... 19: if ((s->control & 0x01) == 0) { /* Operation mode */ s->tx_buff[addr - 10] = val; /* Store to TX buffer directly. */ |