From bd7b4e1fe67561fb8b67c0617b7ea4febd1297a0 Mon Sep 17 00:00:00 2001 From: Thomas Huth Date: Tue, 30 Jun 2020 09:55:20 +0200 Subject: hw/net/can: Add missing fallthrough statements Add fallthrough annotations to be able to compile the code without warnings when using -Wimplicit-fallthrough in our CFLAGS. Looking at the code, it seems like the fallthrough is indeed intended here, so the comments should be appropriate. Signed-off-by: Thomas Huth Reviewed-by: Laurent Vivier Reviewed-by: Pavel Pisa Message-Id: <20200630075520.29825-1-thuth@redhat.com> Signed-off-by: Laurent Vivier --- hw/net/can/can_sja1000.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/net/can/can_sja1000.c b/hw/net/can/can_sja1000.c index ea915a0..2999329 100644 --- a/hw/net/can/can_sja1000.c +++ b/hw/net/can/can_sja1000.c @@ -523,6 +523,7 @@ void can_sja_mem_write(CanSJA1000State *s, hwaddr addr, uint64_t val, break; case 16: /* RX frame information addr16-28. */ s->status_pel |= (1 << 5); /* Set transmit status. */ + /* fallthrough */ case 17 ... 28: if (s->mode & 0x01) { /* Reset mode */ if (addr < 24) { @@ -620,6 +621,7 @@ void can_sja_mem_write(CanSJA1000State *s, hwaddr addr, uint64_t val, break; case 10: s->status_bas |= (1 << 5); /* Set transmit status. */ + /* fallthrough */ case 11 ... 19: if ((s->control & 0x01) == 0) { /* Operation mode */ s->tx_buff[addr - 10] = val; /* Store to TX buffer directly. */ -- cgit v1.1