aboutsummaryrefslogtreecommitdiff
path: root/llvm/docs/Phabricator.rst
AgeCommit message (Collapse)AuthorFilesLines
2024-03-03Removes arcanist and Phabricator information. (#82115)Mark de Wever1-441/+0
Removes old arcanist configuration files and documentation of Phabricator. This only removes the data that seems save to remove.
2023-09-01[Docs] Update documentation for the new GitHub workflow (#65162)Tobias Hieta1-0/+7
This adds first version of a GitHub workflow in the documentation and marks some sections as deprecated. We should clean up these sections ASAP. I was just keen to get something on the documentation site as soon as possible.
2023-08-31Revert "[llvm][docs] commit phabricator patch"Nick Desaulniers1-7/+0
This reverts commit ef4beb8bc76f9d40b7e680cb0c2c7474d80f5a77. It also removes the prior note about needing to patch ``arcanist``. This is patch is no longer necessary: 1. arcanist came out of hibernation and updated to support PHP 8.1. https://github.com/phacility/arcanist/commits/master 2. llvm/llvm-project is moving to github pull requests starting Sept 1 (tomorrow). https://discourse.llvm.org/t/pull-request-migration-schedule/71595 Fixes: #64470 Reviewed By: MaskRay Differential Revision: https://reviews.llvm.org/D159291
2022-07-11[llvm][docs] commit phabricator patchNick Desaulniers1-2/+1
Users upgrading to PHP 8.1 might start observing failures with `arc`. Commit @ychen's suggestions as a patch in tree that can be applied since arcanist is no longer accepting patches. Also, remove the suggestion to apply an external patch updating CA certs. It seems that this was fixed in upstream arcanist before they stopped accepting patches. Compare https://github.com/rashkov/arcanist/commit/e3659d43d8911e91739f3b0c5935598bceb859aa vs https://github.com/rashkov/arcanist/commit/13d3a3c3b100979c34dda261fe21253e3571bc46 Link: https://secure.phabricator.com/book/phabcontrib/article/contributing_code/ Reviewed By: MaskRay Differential Revision: https://reviews.llvm.org/D129232
2022-07-07[docs] Move code contribution from GettingStarted.rst to Contributing.rstFangrui Song1-0/+8
For code contribution, GettingStarted.rst duplicates information in Contributing.rst. The dedicated Contributing.rst is a better place for code contribution, so move the content there. Notes: * D41665 added `Contributing.rst` * D110976 mentioned `git cherry-pick e3659d43d8911e91739f3b0c5935598bceb859aa` workaround Reviewed By: cjdb, fhahn, nickdesaulniers Differential Revision: https://reviews.llvm.org/D129255
2022-03-28Correct a minor point with the Phabricator docsAaron Ballman1-3/+3
The repository field we want to leave blank is on the page as the `Create Diff` button, so merged the instructions about leaving the field blank and clicking the button.
2021-12-16[llvm][docs] Describe how to work with patch series on PhabricatorDavid Spickett1-0/+89
Reviewed By: awarzynski, jhenderson Differential Revision: https://reviews.llvm.org/D115519
2021-11-15[NFC] Trim trailing whitespace in *.rstShao-Ce SUN1-9/+9
2021-10-23[NFC] Correct arc draft optionShivam Gupta1-4/+3
2021-10-05Address a rst format error caught by buildbotPhilip Reames1-2/+2
2021-10-05[docs] Expand the pre-merge testing description a bitPhilip Reames1-1/+25
Core changes are: Be explicit about desired balance between missing true positives and reporting false positives. Mention the opt-out mechanism. Provide links to background, and give description of who to contact if needed. Differential Revision: https://reviews.llvm.org/D110873
2021-08-31[Docs][Phabricator] Mention how to create a draft revisionShivam Gupta1-0/+12
https://llvm.org/docs/Phabricator.html have two links to Arcnist guide but none of them mention how to create a draft revision. It would create some less noise if developers create draft revisoin in this(--draft) way instead of [WIP] tag way. Reviewed By: dblaikie Differential Revision: https://reviews.llvm.org/D108970
2021-04-27[doc] added documentation for pre-merge testingChristian Kühnel1-0/+47
fixes https://github.com/google/llvm-premerge-checks/issues/275 Differential Revision: https://reviews.llvm.org/D100936
2020-12-10[Doc] Update branch name in Phabricator documentationAlexey Bader1-4/+4
master -> main Differential Revision: https://reviews.llvm.org/D93020
2020-09-23Document the `--verbatim` flag from arc to update the description for a ↵Mehdi Amini1-0/+15
phabricator revision
2020-09-23Update Phabricator doc to remove the warning on "arc land": tags a properly ↵Mehdi Amini1-8/+0
handled server side now
2020-09-22[NFC][docs] Fix link.antonio-cortes-perez1-1/+1
The rendered html was (no hyperlink was generated): (see Getting Started <GettingStarted.html#git-pre-push-hook>) Now, it is (with proper hyperlink): (see Git pre-push hook) Reviewed By: mehdi_amini Differential Revision: https://reviews.llvm.org/D88116
2020-08-09[docs] Fix typosKazu Hirata1-1/+1
2020-06-30Update the phabricator docs to reflect the monorepo change.Eric Christopher1-2/+1
Patch by Nathan Froyd! Differential Revision: https://reviews.llvm.org/D82389
2020-06-24Add a git hook script that can be manually setup to run some checks on every ↵Mehdi Amini1-6/+7
push Right now it just catches arcanist noisy tags, and include a script to automatically clean these. Follow up on http://lists.llvm.org/pipermail/llvm-dev/2019-December/137848.html Differential Revision: https://reviews.llvm.org/D80978
2020-06-02Update 'git push' command in GettingStarted guideDiego Caballero1-2/+2
'git push' command, without any other arguments, can do different things depending on the local configuration of Git. This patch updates the 'git push' command with extra arguments to be more resilient to any local configuration. Reviewed By: mehdi_amini Differential Revision: https://reviews.llvm.org/D79964
2020-04-04Add mention of advantages of `arc` in the Phabricator doc.Mehdi Amini1-1/+5
Differential Revision: https://reviews.llvm.org/D76952
2020-04-02[docs] use git diff instead of git format-patchAlexander Lanin1-1/+2
Uploading output from `git format-patch` fails when version has more than 2 dots, e.g. git version 2.24.1.windows.2 which is currently recommended by e.g. GitExtensions or 2.24.1.rc on Linux. Differential Revision: https://reviews.llvm.org/D72374
2020-03-26[docs][Phabricator] git migration related updateJinsong Ji1-4/+11
1.Add instructions to update author when committing other's patch We have updated DeveloperPolicy to show how to change author in https://reviews.llvm.org/D72468 We should also update Phabricator page to include such infomation, in case people follow the steps here and forget to update author info. 2. Replace `git llvm push` with `git push` Reviewed By: probinson Differential Revision: https://reviews.llvm.org/D76718
2020-01-09phab doc: Replace or remove references to svnSylvestre Ledru1-7/+6
2020-01-09phab doc: also document 'arc land'Sylvestre Ledru1-0/+6
2020-01-09phab doc: remove the svn sectionSylvestre Ledru1-14/+0
2019-12-03Add discussion of git-format-patch to Phabricator.htmlKit Barton1-0/+3
Summary: There is a discussion of git-format-patch in GettingStarted guide, but no mention of it in the Phabricator.html page. Reviewers: jyknight, delcypher Reviewed By: delcypher Subscribers: llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D69323
2019-01-14Update GettingStarted guide to recommend that people use the newJames Y Knight1-33/+34
official Git repository. Remove the directions for using git-svn, and demote the prominence of the svn instructions. Also, fix a few other issues while I'm in there: * Mention LLVM_ENABLE_PROJECTS more. * Getting started doesn't need to mention test-suite, but should mention clang and the other projects. * Remove mentions of "configure", since that's long gone. I've also adjusted a few other mentions of svn to point to github, but have not done so comprehensively. Differential Revision: https://reviews.llvm.org/D56654 llvm-svn: 351130
2018-11-07Introduce bug life cycle documentation.Kristof Beyls1-0/+6
Document what is expected during: * triaging * actively working on a bug * closing/resolving Also document how we maintain: * product/component breakdown * default-cc lists per component Differential Revision: https://reviews.llvm.org/D53691 llvm-svn: 346299
2018-01-12[docs] Tweak update to Phabricator docs about setting repository for diffs ↵Ben Hamilton1-4/+6
uploaded via web Summary: In D41919, I missed that there was a *second* step when uploading diffs via web where the repository should be specified. Reviewers: asb, probinson Reviewed By: asb Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D41956 llvm-svn: 322375
2018-01-11[docs] Update Phabricator docs about setting repository for diffs uploaded ↵Ben Hamilton1-5/+5
via web Summary: Docs are out of date now that we have separate repositories for LLVM, Clang, etc. Reviewers: asb Reviewed By: asb Differential Revision: https://reviews.llvm.org/D41919 llvm-svn: 322290
2018-01-04[Docs] Add Contributing page.Florian Hahn1-0/+2
This new page acts as an entry point for (new) contributors to LLVM and provides information about * What to contribute * How to submit a patch * Where to start to learn more about LLVM's architecture and internals. This version of the page duplicates some information from the DeveloperPolicy and Phabricator pages. Subsequent changes should work towards moving information for new developers to this page, where it makes sense. Reviewers: reames, probinson, kristof.beyls, silvas, rengolin, asb Reviewed By: silvas Differential Revision: https://reviews.llvm.org/D41665 llvm-svn: 321804
2017-06-15docs/Phabricator: Better git examples to produce full context patchesMatthias Braun1-1/+2
llvm-svn: 305515
2017-01-05[doc] Fix minor grammatical error in Phabricator.rstAnmol P. Paralkar1-1/+1
Summary: Test commit, fix minor grammatical error in Phabricator.rst Reviewers: delcypher Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D28214 llvm-svn: 291101
2016-12-30[doc] Clarify steps for contributors without commit access.Florian Hahn1-2/+6
Summary: Update the Phabricator docs to clarify how changes are merged for contributors without commit access. Reviewers: delcypher, aaron.ballman Subscribers: aaron.ballman, anmol, llvm-commits Differential Revision: https://reviews.llvm.org/D28184 llvm-svn: 290767
2016-01-14[docs] Improve the documentation on committing code reviewed onDan Liew1-17/+60
Phabricator to trunk. The previous documentation had a few issues: * It did not make it explicit that code could be committed without using the Arcanist tool and how this should be done. * There was also an implicit assumption on using Subversion rather than git-svn in the example using Arcanist. The documentation now explicitly mentions both cases and details how to commit to trunk in each case. Reviewers: klimek, probinson Subscribers: probinson, nwilson, reames, llvm-commits Differential Revision: http://reviews.llvm.org/D15801 llvm-svn: 257764
2016-01-08How to close a review manually.Paul Robinson1-1/+7
llvm-svn: 257180
2015-12-22Add advice on choosing reviewersPaul Robinson1-1/+19
llvm-svn: 256265
2015-08-06docs: Fix typo in Phabricator.rstReid Kleckner1-1/+1
Summary: Fix a small typo in Phabricator.rst: s/your/you. Reviewers: rnk Subscribers: rnk, llvm-commits Differential Revision: http://reviews.llvm.org/D11585 llvm-svn: 244231
2015-08-05Rename all references to old mailing lists to new lists.llvm.org address.Tanya Lattner1-1/+1
llvm-svn: 243999
2015-07-28docs: update arcanist linksMartell Malone1-2/+2
Summary: I need a test commit for using arc. This seems like an appropriate commit to use as a test We may want to port this commit back to 3.7 also Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D11527 llvm-svn: 243408
2015-07-01Expand Phabricator docs slightlyScott Douglass1-7/+9
llvm-svn: 241161
2015-05-27Add some more detailed docs about the current state of Phabricator andChandler Carruth1-1/+11
reviwes.llvm.org to help reduce confusion. llvm-svn: 238295
2015-03-31[docs] add cross-referenceScott Douglass1-1/+3
llvm-svn: 233699
2015-03-30Explain how to abandon a review.Paul Robinson1-1/+14
llvm-svn: 233600
2015-01-13Phabricator calls it "subscriber" not "cc"Paul Robinson1-1/+2
llvm-svn: 225747
2014-07-04Phabricator doc: Explicit the fact that the patch needs to be there before ↵Sylvestre Ledru1-0/+1
the commit llvm-svn: 212328
2014-07-02Also document the 'arc commit' commands in the 'Committing a change' section ↵Sylvestre Ledru1-0/+8
of the Phabricator doc llvm-svn: 212184
2014-06-26Changed Phab 'CC' to 'subscriber'; fixed typoSanjay Patel1-3/+3
llvm-svn: 211793