diff options
author | Craig Topper <craig.topper@gmail.com> | 2019-12-25 10:40:40 -0800 |
---|---|---|
committer | Craig Topper <craig.topper@gmail.com> | 2019-12-25 10:46:00 -0800 |
commit | c5b4a2386b51a18daad7e42040c685c2e9708c47 (patch) | |
tree | 10230c17996ca7724daf50716af03b2bd0780690 /llvm/lib | |
parent | 4af5b23db308c89edeb9fdc6dfbe7e6457b22f1d (diff) | |
download | llvm-c5b4a2386b51a18daad7e42040c685c2e9708c47.zip llvm-c5b4a2386b51a18daad7e42040c685c2e9708c47.tar.gz llvm-c5b4a2386b51a18daad7e42040c685c2e9708c47.tar.bz2 |
[X86] Use zero vector to extend to 512-bits for strict_fp_to_uint v2i1->v2f64 on targets with AVX512F, but not AVX512VL.
In the worst case, this requires a 128-bit move instruction to
implicitly zero the upper bits. In the common case, we should
recognize the producing instruction already zeroed the upper bits.
Diffstat (limited to 'llvm/lib')
-rw-r--r-- | llvm/lib/Target/X86/X86ISelLowering.cpp | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp index 27983a1..c383d92 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -19776,9 +19776,13 @@ SDValue X86TargetLowering::LowerFP_TO_INT(SDValue Op, SelectionDAG &DAG) const { Opc = IsSigned ? ISD::STRICT_FP_TO_SINT : ISD::STRICT_FP_TO_UINT; else Opc = IsSigned ? ISD::FP_TO_SINT : ISD::FP_TO_UINT; - Src = DAG.getNode(ISD::INSERT_SUBVECTOR, dl, MVT::v8f64, - DAG.getUNDEF(MVT::v8f64), - Src, DAG.getIntPtrConstant(0, dl)); + // Need to concat with zero vector for strict fp to avoid spurious + // exceptions. + // TODO: Should we just do this for non-strict as well? + SDValue Tmp = IsStrict ? DAG.getConstantFP(0.0, dl, MVT::v8f64) + : DAG.getUNDEF(MVT::v8f64); + Src = DAG.getNode(ISD::INSERT_SUBVECTOR, dl, MVT::v8f64, Tmp, Src, + DAG.getIntPtrConstant(0, dl)); } SDValue Res, Chain; if (IsStrict) { |