diff options
| author | Fangrui Song <i@maskray.me> | 2021-03-15 12:05:33 -0700 |
|---|---|---|
| committer | Fangrui Song <i@maskray.me> | 2021-03-15 12:05:34 -0700 |
| commit | 5d44c92bf82b7b1055a5a9826695b21eaa43530c (patch) | |
| tree | d8d6ab2a61818cb4f1181bd6b9a9bbe09c1b427f /llvm/lib/CodeGen/TargetInstrInfo.cpp | |
| parent | 29d46760599b32504f4dfda4de69aca8b9f1f65e (diff) | |
| download | llvm-5d44c92bf82b7b1055a5a9826695b21eaa43530c.zip llvm-5d44c92bf82b7b1055a5a9826695b21eaa43530c.tar.gz llvm-5d44c92bf82b7b1055a5a9826695b21eaa43530c.tar.bz2 | |
Change void getNoop(MCInst &NopInst) to MCInst getNop()
Prefer (self-documenting) return values to output parameters (which are
liable to be used).
While here, rename Noop to Nop which is more widely used and improves
consistency with hasEmitNops/setEmitNops/emitNop/etc.
Diffstat (limited to 'llvm/lib/CodeGen/TargetInstrInfo.cpp')
| -rw-r--r-- | llvm/lib/CodeGen/TargetInstrInfo.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/llvm/lib/CodeGen/TargetInstrInfo.cpp b/llvm/lib/CodeGen/TargetInstrInfo.cpp index 165860e..320a013 100644 --- a/llvm/lib/CodeGen/TargetInstrInfo.cpp +++ b/llvm/lib/CodeGen/TargetInstrInfo.cpp @@ -472,9 +472,7 @@ static const TargetRegisterClass *canFoldCopy(const MachineInstr &MI, return nullptr; } -void TargetInstrInfo::getNoop(MCInst &NopInst) const { - llvm_unreachable("Not implemented"); -} +MCInst TargetInstrInfo::getNop() const { llvm_unreachable("Not implemented"); } static MachineInstr *foldPatchpoint(MachineFunction &MF, MachineInstr &MI, ArrayRef<unsigned> Ops, int FrameIndex, |