aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/CodeGen/BasicBlockSections.cpp
diff options
context:
space:
mode:
authorFangrui Song <i@maskray.me>2021-03-15 12:05:33 -0700
committerFangrui Song <i@maskray.me>2021-03-15 12:05:34 -0700
commit5d44c92bf82b7b1055a5a9826695b21eaa43530c (patch)
treed8d6ab2a61818cb4f1181bd6b9a9bbe09c1b427f /llvm/lib/CodeGen/BasicBlockSections.cpp
parent29d46760599b32504f4dfda4de69aca8b9f1f65e (diff)
downloadllvm-5d44c92bf82b7b1055a5a9826695b21eaa43530c.zip
llvm-5d44c92bf82b7b1055a5a9826695b21eaa43530c.tar.gz
llvm-5d44c92bf82b7b1055a5a9826695b21eaa43530c.tar.bz2
Change void getNoop(MCInst &NopInst) to MCInst getNop()
Prefer (self-documenting) return values to output parameters (which are liable to be used). While here, rename Noop to Nop which is more widely used and improves consistency with hasEmitNops/setEmitNops/emitNop/etc.
Diffstat (limited to 'llvm/lib/CodeGen/BasicBlockSections.cpp')
-rw-r--r--llvm/lib/CodeGen/BasicBlockSections.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/llvm/lib/CodeGen/BasicBlockSections.cpp b/llvm/lib/CodeGen/BasicBlockSections.cpp
index 307bfae..1a6eed2 100644
--- a/llvm/lib/CodeGen/BasicBlockSections.cpp
+++ b/llvm/lib/CodeGen/BasicBlockSections.cpp
@@ -309,10 +309,9 @@ static bool avoidZeroOffsetLandingPad(MachineFunction &MF) {
MachineBasicBlock::iterator MI = MBB.begin();
while (!MI->isEHLabel())
++MI;
- MCInst Noop;
- MF.getSubtarget().getInstrInfo()->getNoop(Noop);
+ MCInst Nop = MF.getSubtarget().getInstrInfo()->getNop();
BuildMI(MBB, MI, DebugLoc(),
- MF.getSubtarget().getInstrInfo()->get(Noop.getOpcode()));
+ MF.getSubtarget().getInstrInfo()->get(Nop.getOpcode()));
return false;
}
}