From 5d44c92bf82b7b1055a5a9826695b21eaa43530c Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Mon, 15 Mar 2021 12:05:33 -0700 Subject: Change void getNoop(MCInst &NopInst) to MCInst getNop() Prefer (self-documenting) return values to output parameters (which are liable to be used). While here, rename Noop to Nop which is more widely used and improves consistency with hasEmitNops/setEmitNops/emitNop/etc. --- llvm/lib/CodeGen/BasicBlockSections.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'llvm/lib/CodeGen/BasicBlockSections.cpp') diff --git a/llvm/lib/CodeGen/BasicBlockSections.cpp b/llvm/lib/CodeGen/BasicBlockSections.cpp index 307bfae..1a6eed2 100644 --- a/llvm/lib/CodeGen/BasicBlockSections.cpp +++ b/llvm/lib/CodeGen/BasicBlockSections.cpp @@ -309,10 +309,9 @@ static bool avoidZeroOffsetLandingPad(MachineFunction &MF) { MachineBasicBlock::iterator MI = MBB.begin(); while (!MI->isEHLabel()) ++MI; - MCInst Noop; - MF.getSubtarget().getInstrInfo()->getNoop(Noop); + MCInst Nop = MF.getSubtarget().getInstrInfo()->getNop(); BuildMI(MBB, MI, DebugLoc(), - MF.getSubtarget().getInstrInfo()->get(Noop.getOpcode())); + MF.getSubtarget().getInstrInfo()->get(Nop.getOpcode())); return false; } } -- cgit v1.1