aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/Bitcode/Reader/BitcodeReader.cpp
diff options
context:
space:
mode:
authorMatthias Springer <me@m-sp.org>2024-10-23 07:29:17 -0700
committerGitHub <noreply@github.com>2024-10-23 07:29:17 -0700
commitf18c3e4e7335df282c468b6dff3d29be1822a96d (patch)
tree8a23d649b3aa64fafb4e6fe60fc04874e2a91174 /llvm/lib/Bitcode/Reader/BitcodeReader.cpp
parent8a9921f5692ab33451d11454b40a023ca0965a69 (diff)
downloadllvm-f18c3e4e7335df282c468b6dff3d29be1822a96d.zip
llvm-f18c3e4e7335df282c468b6dff3d29be1822a96d.tar.gz
llvm-f18c3e4e7335df282c468b6dff3d29be1822a96d.tar.bz2
[mlir][Transforms] Dialect Conversion: Simplify materialization fn result type (#113031)
This commit simplifies the result type of materialization functions. Previously: `std::optional<Value>` Now: `Value` The previous implementation allowed 3 possible return values: - Non-null value: The materialization function produced a valid materialization. - `std::nullopt`: The materialization function failed, but another materialization can be attempted. - `Value()`: The materialization failed and so should the dialect conversion. (Previously: Dialect conversion can roll back.) This commit removes the last variant. It is not particularly useful because the dialect conversion will fail anyway if all other materialization functions produced `std::nullopt`. Furthermore, in contrast to type conversions, at least one materialization callback is expected to succeed. In case of a failing type conversion, the current dialect conversion can roll back and try a different pattern. This also used to be the case for materializations, but that functionality was removed with #107109: failed materializations can no longer trigger a rollback. (They can just make the entire dialect conversion fail without rollback.) With this in mind, it is even less useful to have an additional error state for materialization functions. This commit is in preparation of merging the 1:1 and 1:N type converters. Target materializations will have to return multiple values instead of a single one. With this commit, we can keep the API simple: `SmallVector<Value>` instead of `std::optional<SmallVector<Value>>`. Note for LLVM integration: All 1:1 materializations should return `Value` instead of `std::optional<Value>`. Instead of `std::nullopt` return `Value()`.
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp')
0 files changed, 0 insertions, 0 deletions