diff options
| author | Kazuki Sakamoto <kaz@meta.com> | 2023-07-12 14:48:13 -0700 |
|---|---|---|
| committer | Kazuki Sakamoto <kaz@meta.com> | 2023-07-14 10:36:57 -0700 |
| commit | 43b9d62018fe53278dfcd2c46f4937a1664745bd (patch) | |
| tree | 4c322a642aa403b041ae9ef64624add4d34ae7eb /lldb/test/API/python_api | |
| parent | 4083ecfd7f5e13f7906c9d2deafeb6e20ce95b16 (diff) | |
| download | llvm-43b9d62018fe53278dfcd2c46f4937a1664745bd.zip llvm-43b9d62018fe53278dfcd2c46f4937a1664745bd.tar.gz llvm-43b9d62018fe53278dfcd2c46f4937a1664745bd.tar.bz2 | |
[lldb][Windows] Fix TestLocateModuleCallback
D153735 added the tests but it is failing due to POSIX path vs Windows path.
https://lab.llvm.org/buildbot/#/builders/219/builds/4084
Fix it.
- MODULE_PLATFORM_PATH is POSIX path.
- Normalize self.input_dir, FileSpec and SymbolFileSpec fullpath.
Differential Revision: https://reviews.llvm.org/D155124
Diffstat (limited to 'lldb/test/API/python_api')
| -rw-r--r-- | lldb/test/API/python_api/sbplatform/TestLocateModuleCallback.py | 22 |
1 files changed, 14 insertions, 8 deletions
diff --git a/lldb/test/API/python_api/sbplatform/TestLocateModuleCallback.py b/lldb/test/API/python_api/sbplatform/TestLocateModuleCallback.py index 672795f..0e3bdf5 100644 --- a/lldb/test/API/python_api/sbplatform/TestLocateModuleCallback.py +++ b/lldb/test/API/python_api/sbplatform/TestLocateModuleCallback.py @@ -49,7 +49,9 @@ class LocateModuleCallbackTestCase(TestBase): self.assertEqual(MODULE_TRIPLE, module_spec.GetTriple()) - self.assertEqual(MODULE_PLATFORM_PATH, module_spec.GetFileSpec().fullpath) + self.assertEqual( + MODULE_PLATFORM_PATH, Path(module_spec.GetFileSpec().fullpath).as_posix() + ) def check_module(self, module: lldb.SBModule, symbol_file: str, symbol_kind: str): self.assertTrue(module.IsValid()) @@ -61,16 +63,20 @@ class LocateModuleCallbackTestCase(TestBase): self.assertEqual(MODULE_RESOLVED_TRIPLE, module.GetTriple()) - self.assertEqual(MODULE_PLATFORM_PATH, module.GetPlatformFileSpec().fullpath) - self.assertEqual( - str(self.input_dir / MODULE_FILE), - module.GetFileSpec().fullpath, + MODULE_PLATFORM_PATH, Path(module.GetPlatformFileSpec().fullpath).as_posix() ) - self.assertEqual( - str(self.input_dir / symbol_file), - module.GetSymbolFileSpec().fullpath, + self.assertTrue( + (self.input_dir / MODULE_FILE) + .resolve() + .samefile(Path(module.GetFileSpec().fullpath).resolve()) + ) + + self.assertTrue( + (self.input_dir / symbol_file) + .resolve() + .samefile(Path(module.GetSymbolFileSpec().fullpath).resolve()) ) sc_list = module.FindFunctions(MODULE_FUNCTION, lldb.eSymbolTypeCode) |
