diff options
| author | Mike Frysinger <vapier@gentoo.org> | 2021-11-06 13:03:47 -0400 |
|---|---|---|
| committer | Mike Frysinger <vapier@gentoo.org> | 2021-11-06 20:32:31 -0400 |
| commit | 6b015f8977a876c4e1c77fd9732826e8da9c84a4 (patch) | |
| tree | 6fd14c9e8639975f91499fc627eb3ee2898d04af /sim/sh | |
| parent | 7256320b9531e8af14ef75a42c09c47161be1480 (diff) | |
| download | gdb-6b015f8977a876c4e1c77fd9732826e8da9c84a4.zip gdb-6b015f8977a876c4e1c77fd9732826e8da9c84a4.tar.gz gdb-6b015f8977a876c4e1c77fd9732826e8da9c84a4.tar.bz2 | |
sim: sh: fix various parentheses warnings
Add parentheses to a bunch of places where the compiler suggests we
do to avoid confusion to most readers.
Diffstat (limited to 'sim/sh')
| -rw-r--r-- | sim/sh/gencode.c | 18 | ||||
| -rw-r--r-- | sim/sh/interp.c | 4 |
2 files changed, 11 insertions, 11 deletions
diff --git a/sim/sh/gencode.c b/sim/sh/gencode.c index ae44bc8..28b4832 100644 --- a/sim/sh/gencode.c +++ b/sim/sh/gencode.c @@ -1863,7 +1863,7 @@ op ppi_tab[] = "if (i <= 16)", " res = Sz << i;", "else if (i >= 128 - 16)", - " res = (unsigned) Sz >> 128 - i; /* no sign extension */", + " res = (unsigned) Sz >> (128 - i); /* no sign extension */", "else", " {", " RAISE_EXCEPTION (SIGILL);", @@ -1887,7 +1887,7 @@ op ppi_tab[] = " else", " {", " res = Sz << i;", - " res_grd = Sz_grd << i | (unsigned) Sz >> 32 - i;", + " res_grd = Sz_grd << i | (unsigned) Sz >> (32 - i);", " }", " res_grd = SEXT (res_grd);", " carry = res_grd & 1;", @@ -1902,7 +1902,7 @@ op ppi_tab[] = " }", " else", " {", - " res = Sz >> i | Sz_grd << 32 - i;", + " res = Sz >> i | Sz_grd << (32 - i);", " res_grd = Sz_grd >> i;", " }", " carry = Sz >> (i - 1) & 1;", @@ -1973,7 +1973,7 @@ op ppi_tab[] = "ADD_SUB_GE;", "DSR &= ~0xf1;\n", "if (res || res_grd)\n", - " DSR |= greater_equal | res_grd >> 2 & DSR_MASK_N | overflow;\n", + " DSR |= greater_equal | (res_grd >> 2 & DSR_MASK_N) | overflow;\n", "else\n", " DSR |= DSR_MASK_Z | overflow;\n", "DSR |= carry;\n", @@ -1992,7 +1992,7 @@ op ppi_tab[] = "ADD_SUB_GE;", "DSR &= ~0xf1;\n", "if (res || res_grd)\n", - " DSR |= greater_equal | res_grd >> 2 & DSR_MASK_N | overflow;\n", + " DSR |= greater_equal | (res_grd >> 2 & DSR_MASK_N) | overflow;\n", "else\n", " DSR |= DSR_MASK_Z | overflow;\n", "DSR |= carry;\n", @@ -2148,7 +2148,7 @@ op ppi_tab[] = "if (Sy <= 16)", " res = Sx << Sy;", "else if (Sy >= 128 - 16)", - " res = (unsigned) Sx >> 128 - Sy; /* no sign extension */", + " res = (unsigned) Sx >> (128 - Sy); /* no sign extension */", "else", " {", " RAISE_EXCEPTION (SIGILL);", @@ -2171,7 +2171,7 @@ op ppi_tab[] = " else", " {", " res = Sx << Sy;", - " res_grd = Sx_grd << Sy | (unsigned) Sx >> 32 - Sy;", + " res_grd = Sx_grd << Sy | (unsigned) Sx >> (32 - Sy);", " }", " res_grd = SEXT (res_grd);", " carry = res_grd & 1;", @@ -2186,7 +2186,7 @@ op ppi_tab[] = " }", " else", " {", - " res = Sx >> Sy | Sx_grd << 32 - Sy;", + " res = Sx >> Sy | Sx_grd << (32 - Sy);", " res_grd = Sx_grd >> Sy;", " }", " carry = Sx >> (Sy - 1) & 1;", @@ -3347,7 +3347,7 @@ ppi_gensim (void) printf (" }\n"); printf (" DSR &= ~0xf1;\n"); printf (" if (res || res_grd)\n"); - printf (" DSR |= greater_equal | res_grd >> 2 & DSR_MASK_N | overflow;\n"); + printf (" DSR |= greater_equal | (res_grd >> 2 & DSR_MASK_N) | overflow;\n"); printf (" else\n"); printf (" DSR |= DSR_MASK_Z | overflow;\n"); printf (" assign_dc:\n"); diff --git a/sim/sh/interp.c b/sim/sh/interp.c index 4cac8de..2bae448 100644 --- a/sim/sh/interp.c +++ b/sim/sh/interp.c @@ -195,11 +195,11 @@ do { \ #define SET_SR_CS(EXP) SET_SR_BIT ((EXP), SR_MASK_CS) #define SET_BANKN(EXP) \ do { \ - IBNR = (IBNR & 0xfe00) | (EXP & 0x1f); \ + IBNR = (IBNR & 0xfe00) | ((EXP) & 0x1f); \ } while (0) #define SET_ME(EXP) \ do { \ - IBNR = (IBNR & 0x3fff) | ((EXP & 0x3) << 14); \ + IBNR = (IBNR & 0x3fff) | (((EXP) & 0x3) << 14); \ } while (0) #define SET_SR_M(EXP) SET_SR_BIT ((EXP), SR_MASK_M) #define SET_SR_Q(EXP) SET_SR_BIT ((EXP), SR_MASK_Q) |