diff options
| author | Tom Tromey <tom@tromey.com> | 2018-02-21 10:36:55 -0700 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2018-02-26 09:21:08 -0700 |
| commit | 15ce8941e7d2807a3396a6874c528b24c387660a (patch) | |
| tree | 4c1cf8a075385ffb4f6a629617ec0753019d7b75 /opcodes | |
| parent | d7c798565e0f12a821dd399ac3bbf5d49271169a (diff) | |
| download | gdb-15ce8941e7d2807a3396a6874c528b24c387660a.zip gdb-15ce8941e7d2807a3396a6874c528b24c387660a.tar.gz gdb-15ce8941e7d2807a3396a6874c528b24c387660a.tar.bz2 | |
Sign-extend non-bit-fields in unpack_bits_as_long
unpack_bits_as_long is documented as sign-extending its result when
the type is signed. However, it was only doing sign-extension in the
case where the field was a bitfield -- that is, not when the "bitsize"
parameter was 0, indicating the size should be taken from the type.
Also, unpack_bits_as_long was incorrectly computing the shift for
big-endian architectures for the non-bitfield case.
This patch fixes these bugs in a straightforward way. A new selftest
is included.
2018-02-26 Tom Tromey <tom@tromey.com>
* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
unittests/unpack-selftests.c.
* unittests/unpack-selftests.c: New file.
* value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
Diffstat (limited to 'opcodes')
0 files changed, 0 insertions, 0 deletions