* gas/config/tc-arm.c (NEON_ENC_TAB): Add aes entry.

	(neon_type_mask): Add N_UNT.
	(neon_check_type): Don't always decay typed to untyped sizes.
	(do_crypto_2op_1): New function.
	(do_aese): Likewise.
	(do_aesd): Likewise.
	(do_aesmc.8): Likewise.
	(do_aesimc.8): Likewise.
	(insns): Add AES instructions.
	* gas/testsuite/gas/arm/armv8-a+crypto.d: New testcase.
	* gas/testsuite/gas/arm/armv8-a+crypto.s: Likewise.
	* opcodes/arm-dis.c (neon_opcodes): Add support for AES instructions.

5 files changed, 165 insertions, 5 deletions

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 84a5fc9..b756b45 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,5 +1,17 @@
 2012-08-24  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
 
+	* config/tc-arm.c (NEON_ENC_TAB): Add aes entry.
+	(neon_type_mask): Add N_UNT.
+	(neon_check_type): Don't always decay typed to untyped sizes.
+	(do_crypto_2op_1): New function.
+	(do_aese): Likewise.
+	(do_aesd): Likewise.
+	(do_aesmc.8): Likewise.
+	(do_aesimc.8): Likewise.
+	(insns): Add AES instructions.
+
+2012-08-24  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
+
 	* config/tc-arm.c (el_type_type_check): Add handling for 16-bit
 	floating point types.
 	(do_neon_cvttb_2): New function.
diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c
index 6d8d18f..0214d77 100644
--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -12350,7 +12350,8 @@ struct neon_tab_entry
   X(vminnm,	0xe800a40, 0x3200f10, N_INV),		\
   X(vcvta,	0xebc0a40, 0x3bb0000, N_INV),		\
   X(vrintr,	0xeb60a40, 0x3ba0400, N_INV),		\
-  X(vrinta,	0xeb80a40, 0x3ba0400, N_INV)
+  X(vrinta,	0xeb80a40, 0x3ba0400, N_INV),		\
+  X(aes,	0x3b00300, N_INV,     N_INV)
 
 enum neon_opc
 {
@@ -12572,6 +12573,7 @@ enum neon_type_mask
   N_KEY  = 0x1000000, /* Key element (main type specifier).  */
   N_EQK  = 0x2000000, /* Given operand has the same type & size as the key.  */
   N_VFP  = 0x4000000, /* VFP mode: operand size must match register width.  */
+  N_UNT  = 0x8000000, /* Must be explicitly untyped.  */
   N_DBL  = 0x0000001, /* If N_EQK, this operand is twice the size.  */
   N_HLF  = 0x0000002, /* If N_EQK, this operand is half the size.  */
   N_SGN  = 0x0000004, /* If N_EQK, this operand is forced to be signed.  */
@@ -12999,10 +13001,11 @@ neon_check_type (unsigned els, enum neon_shape ns, ...)
           /* If only untyped args are allowed, decay any more specific types to
 	     them. Some instructions only care about signs for some element
 	     sizes, so handle that properly.  */
-          if ((g_size == 8 && (types_allowed & N_8) != 0)
-	      || (g_size == 16 && (types_allowed & N_16) != 0)
-	      || (g_size == 32 && (types_allowed & N_32) != 0)
-	      || (g_size == 64 && (types_allowed & N_64) != 0))
+          if (((types_allowed & N_UNT) == 0)
+	      && ((g_size == 8 && (types_allowed & N_8) != 0)
+		  || (g_size == 16 && (types_allowed & N_16) != 0)
+		  || (g_size == 32 && (types_allowed & N_32) != 0)
+		  || (g_size == 64 && (types_allowed & N_64) != 0)))
 	    g_type = NT_untyped;
 
           if (pass == 0)
@@ -16155,6 +16158,57 @@ do_vrintm (void)
   do_vrint_1 (neon_cvt_mode_m);
 }
 
+/* Crypto v1 instructions.  */
+static void
+do_crypto_2op_1 (unsigned elttype, int op)
+{
+  set_it_insn_type (OUTSIDE_IT_INSN);
+
+  if (neon_check_type (2, NS_QQ, N_EQK | N_UNT, elttype | N_UNT | N_KEY).type
+      == NT_invtype)
+    return;
+
+  inst.error = NULL;
+
+  NEON_ENCODE (INTEGER, inst);
+  inst.instruction |= LOW4 (inst.operands[0].reg) << 12;
+  inst.instruction |= HI1 (inst.operands[0].reg) << 22;
+  inst.instruction |= LOW4 (inst.operands[1].reg);
+  inst.instruction |= HI1 (inst.operands[1].reg) << 5;
+  if (op != -1)
+    inst.instruction |= op << 6;
+
+  if (thumb_mode)
+    inst.instruction |= 0xfc000000;
+  else
+    inst.instruction |= 0xf0000000;
+}
+
+static void
+do_aese (void)
+{
+  do_crypto_2op_1 (N_8, 0);
+}
+
+static void
+do_aesd (void)
+{
+  do_crypto_2op_1 (N_8, 1);
+}
+
+static void
+do_aesmc (void)
+{
+  do_crypto_2op_1 (N_8, 2);
+}
+
+static void
+do_aesimc (void)
+{
+  do_crypto_2op_1 (N_8, 3);
+}
+
+
 
 /* Overall per-instruction processing.	*/
 
@@ -18382,6 +18436,18 @@ static const struct asm_opcode insns[] =
   nUF(vrintp, _vrinta, 2, (RNSDQ, oRNSDQ),		vrintp),
   nUF(vrintm, _vrinta, 2, (RNSDQ, oRNSDQ),		vrintm),
 
+  /* Crypto v1 extensions.  */
+#undef  ARM_VARIANT
+#define ARM_VARIANT & fpu_crypto_ext_armv8
+#undef  THUMB_VARIANT
+#define THUMB_VARIANT & fpu_crypto_ext_armv8
+
+  nUF(aese, _aes, 2, (RNQ, RNQ), aese),
+  nUF(aesd, _aes, 2, (RNQ, RNQ), aesd),
+  nUF(aesmc, _aes, 2, (RNQ, RNQ), aesmc),
+  nUF(aesimc, _aes, 2, (RNQ, RNQ), aesimc),
+
+
 #undef  ARM_VARIANT
 #define ARM_VARIANT  & fpu_fpa_ext_v1  /* Core FPA instruction set (V1).  */
 #undef  THUMB_VARIANT
diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog
index bfaaa6c..d64dbf9 100644
--- a/gas/testsuite/ChangeLog
+++ b/gas/testsuite/ChangeLog
@@ -1,5 +1,10 @@
 2012-08-24  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
 
+	* gas/arm/armv8-a+crypto.d: New testcase.
+	* gas/arm/armv8-a+crypto.s: Likewise.
+
+2012-08-24  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
+
 	* gas/arm/armv8-a+fp.d: Update testcase.
 	* gas/arm/armv8-a+fp.s: Likewise.
 	* gas/arm/half-prec-vfpv3.s: Likewise.
diff --git a/gas/testsuite/gas/arm/armv8-a+crypto.d b/gas/testsuite/gas/arm/armv8-a+crypto.d
new file mode 100644
index 0000000..238f9b6
--- /dev/null
+++ b/gas/testsuite/gas/arm/armv8-a+crypto.d
@@ -0,0 +1,38 @@
+#name: Valid v8-a+cryptov1
+#objdump: -dr --prefix-addresses --show-raw-insn
+
+.*: +file format .*arm.*
+
+Disassembly of section .text:
+0[0-9a-f]+ <[^>]+> f3b00300 	aese.8	q0, q0
+0[0-9a-f]+ <[^>]+> f3b0e30e 	aese.8	q7, q7
+0[0-9a-f]+ <[^>]+> f3f00320 	aese.8	q8, q8
+0[0-9a-f]+ <[^>]+> f3f0e32e 	aese.8	q15, q15
+0[0-9a-f]+ <[^>]+> f3b00340 	aesd.8	q0, q0
+0[0-9a-f]+ <[^>]+> f3b0e34e 	aesd.8	q7, q7
+0[0-9a-f]+ <[^>]+> f3f00360 	aesd.8	q8, q8
+0[0-9a-f]+ <[^>]+> f3f0e36e 	aesd.8	q15, q15
+0[0-9a-f]+ <[^>]+> f3b00380 	aesmc.8	q0, q0
+0[0-9a-f]+ <[^>]+> f3b0e38e 	aesmc.8	q7, q7
+0[0-9a-f]+ <[^>]+> f3f003a0 	aesmc.8	q8, q8
+0[0-9a-f]+ <[^>]+> f3f0e3ae 	aesmc.8	q15, q15
+0[0-9a-f]+ <[^>]+> f3b003c0 	aesimc.8	q0, q0
+0[0-9a-f]+ <[^>]+> f3b0e3ce 	aesimc.8	q7, q7
+0[0-9a-f]+ <[^>]+> f3f003e0 	aesimc.8	q8, q8
+0[0-9a-f]+ <[^>]+> f3f0e3ee 	aesimc.8	q15, q15
+0[0-9a-f]+ <[^>]+> ffb0 0300 	aese.8	q0, q0
+0[0-9a-f]+ <[^>]+> ffb0 e30e 	aese.8	q7, q7
+0[0-9a-f]+ <[^>]+> fff0 0320 	aese.8	q8, q8
+0[0-9a-f]+ <[^>]+> fff0 e32e 	aese.8	q15, q15
+0[0-9a-f]+ <[^>]+> ffb0 0340 	aesd.8	q0, q0
+0[0-9a-f]+ <[^>]+> ffb0 e34e 	aesd.8	q7, q7
+0[0-9a-f]+ <[^>]+> fff0 0360 	aesd.8	q8, q8
+0[0-9a-f]+ <[^>]+> fff0 e36e 	aesd.8	q15, q15
+0[0-9a-f]+ <[^>]+> ffb0 0380 	aesmc.8	q0, q0
+0[0-9a-f]+ <[^>]+> ffb0 e38e 	aesmc.8	q7, q7
+0[0-9a-f]+ <[^>]+> fff0 03a0 	aesmc.8	q8, q8
+0[0-9a-f]+ <[^>]+> fff0 e3ae 	aesmc.8	q15, q15
+0[0-9a-f]+ <[^>]+> ffb0 03c0 	aesimc.8	q0, q0
+0[0-9a-f]+ <[^>]+> ffb0 e3ce 	aesimc.8	q7, q7
+0[0-9a-f]+ <[^>]+> fff0 03e0 	aesimc.8	q8, q8
+0[0-9a-f]+ <[^>]+> fff0 e3ee 	aesimc.8	q15, q15
diff --git a/gas/testsuite/gas/arm/armv8-a+crypto.s b/gas/testsuite/gas/arm/armv8-a+crypto.s
new file mode 100644
index 0000000..4f01b79
--- /dev/null
+++ b/gas/testsuite/gas/arm/armv8-a+crypto.s
@@ -0,0 +1,39 @@
+	.syntax unified
+	.arch armv8-a
+	.arch_extension crypto
+
+	.arm
+	aese.8	q0, q0
+	aese.8	q7, q7
+	aese.8	q8, q8
+	aese.8	q15, q15
+	aesd.8	q0, q0
+	aesd.8	q7, q7
+	aesd.8	q8, q8
+	aesd.8	q15, q15
+	aesmc.8	q0, q0
+	aesmc.8	q7, q7
+	aesmc.8	q8, q8
+	aesmc.8	q15, q15
+	aesimc.8	q0, q0
+	aesimc.8	q7, q7
+	aesimc.8	q8, q8
+	aesimc.8	q15, q15
+
+	.thumb
+	aese.8	q0, q0
+	aese.8	q7, q7
+	aese.8	q8, q8
+	aese.8	q15, q15
+	aesd.8	q0, q0
+	aesd.8	q7, q7
+	aesd.8	q8, q8
+	aesd.8	q15, q15
+	aesmc.8	q0, q0
+	aesmc.8	q7, q7
+	aesmc.8	q8, q8
+	aesmc.8	q15, q15
+	aesimc.8	q0, q0
+	aesimc.8	q7, q7
+	aesimc.8	q8, q8
+	aesimc.8	q15, q15