diff options
| author | Jan Beulich <jbeulich@suse.com> | 2024-01-09 13:50:27 +0100 |
|---|---|---|
| committer | Jan Beulich <jbeulich@suse.com> | 2024-01-09 13:50:27 +0100 |
| commit | 7c3df3c680c2bee0b17e60bfbadc751c67e05ed0 (patch) | |
| tree | cfd73af5e18b93d100a381b2bfd16716f8147492 /gas | |
| parent | 7440781b67631ebdf1b0587724f5d77c3748b034 (diff) | |
| download | gdb-7c3df3c680c2bee0b17e60bfbadc751c67e05ed0.zip gdb-7c3df3c680c2bee0b17e60bfbadc751c67e05ed0.tar.gz gdb-7c3df3c680c2bee0b17e60bfbadc751c67e05ed0.tar.bz2 | |
x86: add missing APX logic to cpu_flags_match()
As already indicated during review, we can't get away without certain
adjustments here: Without these, respective {evex}-prefixed insns are
assembled to APX encodings even when APX_F is turned off.
While there also extend the respective comment in the opcode table, to
explain why this construct is used.
Diffstat (limited to 'gas')
| -rw-r--r-- | gas/config/tc-i386.c | 24 | ||||
| -rw-r--r-- | gas/testsuite/gas/i386/x86-64-apx-egpr-promote-inval.l | 7 | ||||
| -rw-r--r-- | gas/testsuite/gas/i386/x86-64-apx-egpr-promote-inval.s | 10 |
3 files changed, 41 insertions, 0 deletions
diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c index f7276c1..d599306 100644 --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -1939,6 +1939,30 @@ cpu_flags_match (const insn_template *t) any.bitfield.cpuavx512vl = 0; } } + + /* Dual non-APX/APX templates need massaging from what APX_F() in the + opcode table has produced. While the direct transformation of the + incoming cpuid&(cpuid|APX_F) would be to cpuid&(cpuid) / cpuid&(APX_F) + respectively, it's cheaper to move to just cpuid / cpuid&APX_F + instead. */ + if (any.bitfield.cpuapx_f + && (any.bitfield.cpubmi || any.bitfield.cpubmi2 + || any.bitfield.cpuavx512f || any.bitfield.cpuavx512bw + || any.bitfield.cpuavx512dq || any.bitfield.cpuamx_tile + || any.bitfield.cpucmpccxadd)) + { + /* These checks (verifying that APX_F() was properly used in the + opcode table entry) make sure there's no need for an "else" to + the "if()" below. */ + gas_assert (!cpu_flags_all_zero (&all)); + cpu = cpu_flags_and (all, any); + gas_assert (cpu_flags_equal (&cpu, &all)); + + if (need_evex_encoding (t)) + all = any; + + memset (&any, 0, sizeof (any)); + } } if (flag_code != CODE_64BIT) diff --git a/gas/testsuite/gas/i386/x86-64-apx-egpr-promote-inval.l b/gas/testsuite/gas/i386/x86-64-apx-egpr-promote-inval.l index f8701d7..6f06df9 100644 --- a/gas/testsuite/gas/i386/x86-64-apx-egpr-promote-inval.l +++ b/gas/testsuite/gas/i386/x86-64-apx-egpr-promote-inval.l @@ -13,6 +13,13 @@ .*:25: Error: `andn' is not supported on `x86_64.nobmi' .*:28: Error: `bzhi' is not supported on `x86_64.nobmi2' .*:29: Error: `bzhi' is not supported on `x86_64.nobmi2' +.*:33: Error: .*`andn'.* +.*:34: Error: .*`bzhi'.* +.*:35: Error: .*`kmovw'.* +.*:36: Error: .*`kmovq'.* +.*:37: Error: .*`kmovb'.* +.*:38: Error: .*`ldtilecfg'.* +.*:39: Error: .*`cmpexadd'.* GAS LISTING .* #... [ ]*1[ ]+\# Check illegal 64bit APX EVEX promoted instructions diff --git a/gas/testsuite/gas/i386/x86-64-apx-egpr-promote-inval.s b/gas/testsuite/gas/i386/x86-64-apx-egpr-promote-inval.s index 2ea4741..5e4e08f 100644 --- a/gas/testsuite/gas/i386/x86-64-apx-egpr-promote-inval.s +++ b/gas/testsuite/gas/i386/x86-64-apx-egpr-promote-inval.s @@ -27,3 +27,13 @@ .arch .nobmi2 bzhi %r16,%r15,%r11 bzhi %r15,%r15,%r11 + + .arch default + .arch .noapx_f + {evex} andn %r15, %r15, %r11 + {evex} bzhi %r15, %r15, %r11 + {evex} kmovw %k1, %r8d + {evex} kmovq %k1, %r8 + {evex} kmovb %k1, %r8d + {evex} ldtilecfg (%r8) + {evex} cmpexadd %rax, %rcx, (%r8) |