diff options
| author | Thomas Preud'homme <thomas.preudhomme@linaro.org> | 2018-11-01 17:18:24 +0000 |
|---|---|---|
| committer | Thomas Preud'homme <thomas.preudhomme@linaro.org> | 2018-11-01 17:19:17 +0000 |
| commit | 33ea299c25134ce23805faa6b2b1e7fe6327f6bb (patch) | |
| tree | 4ed73573972f15d6b8010fc846f6550677bf3e00 /gas | |
| parent | cdcda965ea4c70c80b9f8c294597e991417ff9d5 (diff) | |
| download | gdb-33ea299c25134ce23805faa6b2b1e7fe6327f6bb.zip gdb-33ea299c25134ce23805faa6b2b1e7fe6327f6bb.tar.gz gdb-33ea299c25134ce23805faa6b2b1e7fe6327f6bb.tar.bz2 | |
Fix ld action in run_dump_test
run_dump_test proposes an ld action but when trying to make use of it in
a gas test it gave me some Tcl error. It turns out that it references
the check_shared_lib_support procedure and ld_elf_shared_opt variable
both only available in ld-lib.exp. I've thus moved the procedure in
binutils-common.exp and defined the variable needed in the various
default.exp of testsuite that seem to be using run_dump_test.
Since check_shared_lib_support itself references the ld variable not
defined in binutils-common I've defined it from LD in run_dump_test and
fixed LD and LDFLAGS to be defined as expected by run_dump_test in the
various default.exp of testsuite using run_dump_test.
2018-11-01 Thomas Preud'homme <thomas.preudhomme@linaro.org>
binutils/
* testsuite/config/default.exp: Define LD, LDFLAGS and
ld_elf_shared_opt.
* testsuite/lib/binutils-common.exp (check_shared_lib_support): Moved
from ld-lib.exp.
(run_dump_test): Set ld to $LD.
gas/
* testsuite/config/default.exp: Define LD, LDFLAGS and
ld_elf_shared_opt.
ld/
* testsuite/lib/ld-lib.exp (check_shared_lib_support): Moved to
binutils-common.exp.
Diffstat (limited to 'gas')
| -rw-r--r-- | gas/ChangeLog | 5 | ||||
| -rw-r--r-- | gas/testsuite/config/default.exp | 8 |
2 files changed, 13 insertions, 0 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog index 86eb344..eef02b8 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,8 @@ +2018-11-01 Thomas Preud'homme <thomas.preudhomme@linaro.org> + + * testsuite/config/default.exp: Define LD, LDFLAGS and + ld_elf_shared_opt. + 2018-10-31 Andre Vieira <andre.simoesdiasvieira@arm.com> * testsuite/gas/arm/armv8-a+rdma-warning.d: Remove objdump execution. diff --git a/gas/testsuite/config/default.exp b/gas/testsuite/config/default.exp index 888e90d..b76c5ba 100644 --- a/gas/testsuite/config/default.exp +++ b/gas/testsuite/config/default.exp @@ -26,6 +26,14 @@ if ![info exists ASFLAGS] then { set ASFLAGS "" } +if ![info exists LD] then { + set LD [findfile $base_dir/../../ld/ld-new $base_dir/../../ld/ld-new [transform ld]] +} +if ![info exists LDFLAGS] then { + set LDFLAGS "" +} +set ld_elf_shared_opt "-z norelro" + if ![info exists OBJDUMP] then { set OBJDUMP [findfile $base_dir/../../binutils/objdump \ $base_dir/../../binutils/objdump \ |