diff options
author | Peter Bergner <bergner@linux.ibm.com> | 2022-03-04 09:03:44 -0600 |
---|---|---|
committer | Peter Bergner <bergner@linux.ibm.com> | 2022-03-04 09:04:21 -0600 |
commit | cb16bc3b5f34733ef9bbf8d2e3acacdecb099a62 (patch) | |
tree | b1614c76bd39cb049682a22f202139ad285e0f6a /gcc/common | |
parent | e28eb86c18ed765dceb3c56471a848e9f0e120ff (diff) | |
download | gcc-cb16bc3b5f34733ef9bbf8d2e3acacdecb099a62.zip gcc-cb16bc3b5f34733ef9bbf8d2e3acacdecb099a62.tar.gz gcc-cb16bc3b5f34733ef9bbf8d2e3acacdecb099a62.tar.bz2 |
rs6000: Allow -mlong-double-64 after -mabi={ibm,ieee}longdouble [PR104208, PR87496]
The glibc build is showing a build error due to extra "error" checking from my
PR87496 fix. That checking was overeager, disallowing setting the long double
size to 64-bits if the 128-bit long double ABI had already been specified.
Now we only emit an error if we specify a 128-bit long double ABI if our
long double size is not 128 bits. This also fixes an erroneous error when
-mabi=ieeelongdouble is used and ISA 2.06 is not enabled, but the long double
size has been changed to 64 bits.
2022-03-04 Peter Bergner <bergner@linux.ibm.com>
gcc/
PR target/87496
PR target/104208
* config/rs6000/rs6000.cc (rs6000_option_override_internal): Make the
ISA 2.06 requirement for -mabi=ieeelongdouble conditional on
-mlong-double-128.
Move the -mabi=ieeelongdouble and -mabi=ibmlongdouble error checking
from here...
* common/config/rs6000/rs6000-common.cc (rs6000_handle_option):
... to here.
gcc/testsuite/
PR target/87496
PR target/104208
* gcc.target/powerpc/pr104208-1.c: New test.
* gcc.target/powerpc/pr104208-2.c: Likewise.
* gcc.target/powerpc/pr87496-2.c: Swap long double options to trigger
the expected error.
* gcc.target/powerpc/pr87496-3.c: Likewise.
Diffstat (limited to 'gcc/common')
-rw-r--r-- | gcc/common/config/rs6000/rs6000-common.cc | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/gcc/common/config/rs6000/rs6000-common.cc b/gcc/common/config/rs6000/rs6000-common.cc index 97dff3a..8e393d0 100644 --- a/gcc/common/config/rs6000/rs6000-common.cc +++ b/gcc/common/config/rs6000/rs6000-common.cc @@ -227,6 +227,16 @@ rs6000_handle_option (struct gcc_options *opts, struct gcc_options *opts_set, } break; + case OPT_mabi_ibmlongdouble: + case OPT_mabi_ieeelongdouble: + if (opts->x_rs6000_long_double_type_size == 64) + { + error_at (loc, "option %<%s%> requires %<-mlong-double-128%>", + decoded->orig_option_with_args_text); + return true; + } + break; + case OPT_mrecip: opts->x_rs6000_recip_name = (value) ? "default" : "none"; break; |