diff options
| author | Mike Frysinger <vapier@gentoo.org> | 2023-12-24 05:13:42 -0500 |
|---|---|---|
| committer | Mike Frysinger <vapier@gentoo.org> | 2024-01-06 23:30:43 -0500 |
| commit | 012c1f072f7f1611c86a912f0964e45136ea38cc (patch) | |
| tree | 0349c03edfa8d83fe31e8890e762d4d52aae28da /sim | |
| parent | 6541385ca26947a6a212e942ec2a87afaa7b9f5c (diff) | |
| download | binutils-012c1f072f7f1611c86a912f0964e45136ea38cc.zip binutils-012c1f072f7f1611c86a912f0964e45136ea38cc.tar.gz binutils-012c1f072f7f1611c86a912f0964e45136ea38cc.tar.bz2 | |
sim: cris: add error fallbacks when decoding condition & swap codes
The condition & swap code decoder only checks known bits and sets
based on that. If the variable is out of range, it ends up returning
uninitialized data. Turn that case into a hard error.
This fixes build warnings like:
sim/cris/semcrisv10f-switch.c:13115:11: error:
variable 'tmp_condres' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
Diffstat (limited to 'sim')
| -rw-r--r-- | sim/cris/semcrisv10f-switch.c | 12 | ||||
| -rw-r--r-- | sim/cris/semcrisv32f-switch.c | 12 |
2 files changed, 24 insertions, 0 deletions
diff --git a/sim/cris/semcrisv10f-switch.c b/sim/cris/semcrisv10f-switch.c index cae56fd..8441c22 100644 --- a/sim/cris/semcrisv10f-switch.c +++ b/sim/cris/semcrisv10f-switch.c @@ -11091,6 +11091,9 @@ SET_H_VBIT_MOVE (0); ; ORSI (ANDSI (SLLSI (tmp_tmpb, 8), 0xff00ff00), ANDSI (SRLSI (tmp_tmpb, 8), 16711935)); }); ; ORSI (SLLSI (ANDSI (tmp_tmpr, 16843009), 7), ORSI (SLLSI (ANDSI (tmp_tmpr, 33686018), 5), ORSI (SLLSI (ANDSI (tmp_tmpr, 67372036), 3), ORSI (SLLSI (ANDSI (tmp_tmpr, 134744072), 1), ORSI (SRLSI (ANDSI (tmp_tmpr, 269488144), 1), ORSI (SRLSI (ANDSI (tmp_tmpr, 538976288), 3), ORSI (SRLSI (ANDSI (tmp_tmpr, 1077952576), 5), SRLSI (ANDSI (tmp_tmpr, 0x80808080), 7)))))))); }); } + else { +cgen_rtx_error (current_cpu, "Unknown swapcode"); +} ; tmp_tmpres; }); { SI opval = tmp_tmpd; @@ -12110,6 +12113,9 @@ if (NESI (ANDSI (tmp_tmp, SLLSI (1, 7)), 0)) { else if (EQSI (tmp_tmpcond, 15)) { tmp_condres = CPU (h_pbit); } + else { +cgen_rtx_error (current_cpu, "Unknown condition code"); +} ; tmp_condres; }); crisv10f_branch_taken (current_cpu, pc, FLD (i_o_pcrel), tmp_truthval); { @@ -12242,6 +12248,9 @@ if (tmp_truthval) { else if (EQSI (tmp_tmpcond, 15)) { tmp_condres = CPU (h_pbit); } + else { +cgen_rtx_error (current_cpu, "Unknown condition code"); +} ; tmp_condres; }); crisv10f_branch_taken (current_cpu, pc, FLD (i_o_word_pcrel), tmp_truthval); { @@ -13115,6 +13124,9 @@ SET_H_VBIT_MOVE (0); else if (EQSI (tmp_tmpcond, 15)) { tmp_condres = CPU (h_pbit); } + else { +cgen_rtx_error (current_cpu, "Unknown condition code"); +} ; tmp_condres; }); { SI opval = ZEXTBISI (tmp_truthval); diff --git a/sim/cris/semcrisv32f-switch.c b/sim/cris/semcrisv32f-switch.c index db2f7aa..77cd07a 100644 --- a/sim/cris/semcrisv32f-switch.c +++ b/sim/cris/semcrisv32f-switch.c @@ -11361,6 +11361,9 @@ SET_H_VBIT_MOVE (0); ; ORSI (ANDSI (SLLSI (tmp_tmpb, 8), 0xff00ff00), ANDSI (SRLSI (tmp_tmpb, 8), 16711935)); }); ; ORSI (SLLSI (ANDSI (tmp_tmpr, 16843009), 7), ORSI (SLLSI (ANDSI (tmp_tmpr, 33686018), 5), ORSI (SLLSI (ANDSI (tmp_tmpr, 67372036), 3), ORSI (SLLSI (ANDSI (tmp_tmpr, 134744072), 1), ORSI (SRLSI (ANDSI (tmp_tmpr, 269488144), 1), ORSI (SRLSI (ANDSI (tmp_tmpr, 538976288), 3), ORSI (SRLSI (ANDSI (tmp_tmpr, 1077952576), 5), SRLSI (ANDSI (tmp_tmpr, 0x80808080), 7)))))))); }); } + else { +cgen_rtx_error (current_cpu, "Unknown swapcode"); +} ; tmp_tmpres; }); { SI opval = tmp_tmpd; @@ -12510,6 +12513,9 @@ crisv32f_rfg_handler (current_cpu, pc); else if (EQSI (tmp_tmpcond, 15)) { tmp_condres = CPU (h_pbit); } + else { +cgen_rtx_error (current_cpu, "Unknown condition code"); +} ; tmp_condres; }); crisv32f_branch_taken (current_cpu, pc, FLD (i_o_pcrel), tmp_truthval); { @@ -12642,6 +12648,9 @@ if (tmp_truthval) { else if (EQSI (tmp_tmpcond, 15)) { tmp_condres = CPU (h_pbit); } + else { +cgen_rtx_error (current_cpu, "Unknown condition code"); +} ; tmp_condres; }); crisv32f_branch_taken (current_cpu, pc, FLD (i_o_word_pcrel), tmp_truthval); { @@ -13430,6 +13439,9 @@ SET_H_VBIT_MOVE (0); else if (EQSI (tmp_tmpcond, 15)) { tmp_condres = CPU (h_pbit); } + else { +cgen_rtx_error (current_cpu, "Unknown condition code"); +} ; tmp_condres; }); { SI opval = ZEXTBISI (tmp_truthval); |