aboutsummaryrefslogtreecommitdiff
path: root/riscv/csrs.cc
diff options
context:
space:
mode:
authorYenHaoChen <howard25336284@gmail.com>2024-02-02 14:14:28 +0800
committerYenHaoChen <howard25336284@gmail.com>2024-02-06 08:21:59 +0800
commit928743b105becf2bedf704b97d220825690c0c52 (patch)
tree5f312eb8b1c42fb42e0c4c1b2baf12f9417aeb61 /riscv/csrs.cc
parent7c890632ec91104fe6ccd9f16f70842c4412a1fd (diff)
downloadriscv-isa-sim-928743b105becf2bedf704b97d220825690c0c52.zip
riscv-isa-sim-928743b105becf2bedf704b97d220825690c0c52.tar.gz
riscv-isa-sim-928743b105becf2bedf704b97d220825690c0c52.tar.bz2
Teach Sstc to respect xenvcfg.STCE
When menvcfg.STCE=0, mip.STIP reverts to its defined behavior as if unsupporting Sstc extension. When henvcfg.STCE=0, mip.VSTIP reverts to its defined behavior as if unsupporting Sstc extension. [https://github.com/riscv/riscv-time-compare/issues/5] The previous Sstc implementation does not respect the xenvcfg.STCE. In other words, the Sstc may assert mip.STIP (mip.VSTIP) when menvcfg.STCE=0 (henvcfg.STCE=0), which is a misbehaving.
Diffstat (limited to 'riscv/csrs.cc')
-rw-r--r--riscv/csrs.cc6
1 files changed, 4 insertions, 2 deletions
diff --git a/riscv/csrs.cc b/riscv/csrs.cc
index b76b496..f00f88e 100644
--- a/riscv/csrs.cc
+++ b/riscv/csrs.cc
@@ -1075,7 +1075,8 @@ void time_counter_csr_t::sync(const reg_t val) noexcept {
if (proc->extension_enabled(EXT_SSTC)) {
const reg_t mip_val = (shadow_val >= state->stimecmp->read() ? MIP_STIP : 0) |
(shadow_val + state->htimedelta->read() >= state->vstimecmp->read() ? MIP_VSTIP : 0);
- state->mip->backdoor_write_with_mask(MIP_STIP | MIP_VSTIP, mip_val);
+ const reg_t mask = ((state->menvcfg->read() & MENVCFG_STCE) ? MIP_STIP : 0) | ((state->henvcfg->read() & HENVCFG_STCE) ? MIP_VSTIP : 0);
+ state->mip->backdoor_write_with_mask(mask, mip_val);
}
}
@@ -1533,7 +1534,8 @@ stimecmp_csr_t::stimecmp_csr_t(processor_t* const proc, const reg_t addr, const
}
bool stimecmp_csr_t::unlogged_write(const reg_t val) noexcept {
- state->mip->backdoor_write_with_mask(intr_mask, state->time->read() >= val ? intr_mask : 0);
+ const reg_t mask = ((state->menvcfg->read() & MENVCFG_STCE) ? MIP_STIP : 0) | ((state->henvcfg->read() & HENVCFG_STCE) ? MIP_VSTIP : 0);
+ state->mip->backdoor_write_with_mask(mask, state->time->read() >= val ? intr_mask : 0);
return basic_csr_t::unlogged_write(val);
}