diff options
| author | Daniel P. Berrangé <berrange@redhat.com> | 2025-06-10 13:36:44 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2025-06-12 13:39:08 -0400 |
| commit | 9a23075cef1ac6e73a95a489ac72f41c573ceb9b (patch) | |
| tree | 677efc662c02eecd9fed73cbc1e5c4bb6a9abb06 | |
| parent | 45bb7fb21c8d18294a9f92da99d01ab3c67c7df2 (diff) | |
| download | qemu-9a23075cef1ac6e73a95a489ac72f41c573ceb9b.zip qemu-9a23075cef1ac6e73a95a489ac72f41c573ceb9b.tar.gz qemu-9a23075cef1ac6e73a95a489ac72f41c573ceb9b.tar.bz2 | |
chardev/char-socket: skip automatic zero-init of large array
The 'tcp_chr_read' method has a 4k byte array used for copying
data between the socket and device. Skip the automatic zero-init
of this array to eliminate the performance overhead in the I/O
hot path.
The 'buf' array will be fully initialized when reading data off
the network socket.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20250610123709.835102-7-berrange@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
| -rw-r--r-- | chardev/char-socket.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chardev/char-socket.c b/chardev/char-socket.c index e8dd293..1e83139 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -497,7 +497,7 @@ static gboolean tcp_chr_read(QIOChannel *chan, GIOCondition cond, void *opaque) { Chardev *chr = CHARDEV(opaque); SocketChardev *s = SOCKET_CHARDEV(opaque); - uint8_t buf[CHR_READ_BUF_LEN]; + QEMU_UNINITIALIZED uint8_t buf[CHR_READ_BUF_LEN]; int len, size; if ((s->state != TCP_CHARDEV_STATE_CONNECTED) || |