diff options
| author | Daniel P. Berrangé <berrange@redhat.com> | 2025-06-10 13:36:43 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2025-06-12 13:39:08 -0400 |
| commit | 45bb7fb21c8d18294a9f92da99d01ab3c67c7df2 (patch) | |
| tree | 3c3e7b6cda9418fe478a60f3d4415b69764005be | |
| parent | a503bdc22b91869e3bf45522e36b122889465306 (diff) | |
| download | qemu-45bb7fb21c8d18294a9f92da99d01ab3c67c7df2.zip qemu-45bb7fb21c8d18294a9f92da99d01ab3c67c7df2.tar.gz qemu-45bb7fb21c8d18294a9f92da99d01ab3c67c7df2.tar.bz2 | |
chardev/char-pty: skip automatic zero-init of large array
The 'pty_chr_read' method has a 4k byte array used for copying
data between the PTY and device. Skip the automatic zero-init
of this array to eliminate the performance overhead in the I/O
hot path.
The 'buf' array will be fully initialized when reading data off
the PTY.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20250610123709.835102-6-berrange@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
| -rw-r--r-- | chardev/char-pty.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chardev/char-pty.c b/chardev/char-pty.c index c28554e..674e9b3 100644 --- a/chardev/char-pty.c +++ b/chardev/char-pty.c @@ -154,7 +154,7 @@ static gboolean pty_chr_read(QIOChannel *chan, GIOCondition cond, void *opaque) Chardev *chr = CHARDEV(opaque); PtyChardev *s = PTY_CHARDEV(opaque); gsize len; - uint8_t buf[CHR_READ_BUF_LEN]; + QEMU_UNINITIALIZED uint8_t buf[CHR_READ_BUF_LEN]; ssize_t ret; len = sizeof(buf); |