diff options
| author | Simon Pilgrim <llvm-dev@redking.me.uk> | 2020-02-20 11:10:56 +0000 |
|---|---|---|
| committer | Simon Pilgrim <llvm-dev@redking.me.uk> | 2020-02-20 12:03:08 +0000 |
| commit | 6085593c128e91fd7db998c5441ebe120c7e4f04 (patch) | |
| tree | 3e6f57dab3e9ddb94d5c1dfd2e66fadb0f31bbb7 /llvm/lib | |
| parent | dbfc682e2ba2581e214fabb04ba1b555ff8b274a (diff) | |
| download | llvm-6085593c128e91fd7db998c5441ebe120c7e4f04.zip llvm-6085593c128e91fd7db998c5441ebe120c7e4f04.tar.gz llvm-6085593c128e91fd7db998c5441ebe120c7e4f04.tar.bz2 | |
[AMDGPU] simplifyI24 - replace GetDemandedBits with SimplifyMultipleUseDemandedBits
GetDemandedBits mostly just calls SimplifyMultipleUseDemandedBits now, but it does a very blunt constant simplification that SimplifyMultipleUseDemandedBits avoids.
If we need to demand bits from constants we should handle this through ShrinkDemandedConstant/targetShrinkDemandedConstant.
@arsenm confirmed that the sign extended immediates are better for code size.
Differential Revision: https://reviews.llvm.org/D74857
Diffstat (limited to 'llvm/lib')
| -rw-r--r-- | llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp b/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp index 8cbe448..79a0d20 100644 --- a/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp +++ b/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp @@ -2822,6 +2822,7 @@ static bool isI24(SDValue Op, SelectionDAG &DAG) { static SDValue simplifyI24(SDNode *Node24, TargetLowering::DAGCombinerInfo &DCI) { SelectionDAG &DAG = DCI.DAG; + const TargetLowering &TLI = DAG.getTargetLoweringInfo(); bool IsIntrin = Node24->getOpcode() == ISD::INTRINSIC_WO_CHAIN; SDValue LHS = IsIntrin ? Node24->getOperand(1) : Node24->getOperand(0); @@ -2835,11 +2836,11 @@ static SDValue simplifyI24(SDNode *Node24, APInt Demanded = APInt::getLowBitsSet(LHS.getValueSizeInBits(), 24); - // First try to simplify using GetDemandedBits which allows the operands to - // have other uses, but will only perform simplifications that involve - // bypassing some nodes for this user. - SDValue DemandedLHS = DAG.GetDemandedBits(LHS, Demanded); - SDValue DemandedRHS = DAG.GetDemandedBits(RHS, Demanded); + // First try to simplify using SimplifyMultipleUseDemandedBits which allows + // the operands to have other uses, but will only perform simplifications that + // involve bypassing some nodes for this user. + SDValue DemandedLHS = TLI.SimplifyMultipleUseDemandedBits(LHS, Demanded, DAG); + SDValue DemandedRHS = TLI.SimplifyMultipleUseDemandedBits(RHS, Demanded, DAG); if (DemandedLHS || DemandedRHS) return DAG.getNode(NewOpcode, SDLoc(Node24), Node24->getVTList(), DemandedLHS ? DemandedLHS : LHS, @@ -2847,7 +2848,6 @@ static SDValue simplifyI24(SDNode *Node24, // Now try SimplifyDemandedBits which can simplify the nodes used by our // operands if this node is the only user. - const TargetLowering &TLI = DAG.getTargetLoweringInfo(); if (TLI.SimplifyDemandedBits(LHS, Demanded, DCI)) return SDValue(Node24, 0); if (TLI.SimplifyDemandedBits(RHS, Demanded, DCI)) |