diff options
author | Kazu Hirata <kazu@google.com> | 2021-09-18 09:29:24 -0700 |
---|---|---|
committer | Kazu Hirata <kazu@google.com> | 2021-09-18 09:29:24 -0700 |
commit | 48719e3b1861a9b8216dc3aa4dce1b05389f0aff (patch) | |
tree | 2a749bac3b0a39c118d0612031b2b88042db0481 /llvm/lib | |
parent | 2b44a7325c56cdd78bbcfab7ff7a00126aa5c822 (diff) | |
download | llvm-48719e3b1861a9b8216dc3aa4dce1b05389f0aff.zip llvm-48719e3b1861a9b8216dc3aa4dce1b05389f0aff.tar.gz llvm-48719e3b1861a9b8216dc3aa4dce1b05389f0aff.tar.bz2 |
[CodeGen] Use make_early_inc_range (NFC)
Diffstat (limited to 'llvm/lib')
-rw-r--r-- | llvm/lib/CodeGen/BranchFolding.cpp | 6 | ||||
-rw-r--r-- | llvm/lib/CodeGen/CodeGenPrepare.cpp | 10 | ||||
-rw-r--r-- | llvm/lib/CodeGen/GlobalISel/Localizer.cpp | 5 | ||||
-rw-r--r-- | llvm/lib/CodeGen/StackProtector.cpp | 19 |
4 files changed, 17 insertions, 23 deletions
diff --git a/llvm/lib/CodeGen/BranchFolding.cpp b/llvm/lib/CodeGen/BranchFolding.cpp index 2f07c4b..5ac8f49 100644 --- a/llvm/lib/CodeGen/BranchFolding.cpp +++ b/llvm/lib/CodeGen/BranchFolding.cpp @@ -1752,10 +1752,8 @@ ReoptimizeBlock: bool BranchFolder::HoistCommonCode(MachineFunction &MF) { bool MadeChange = false; - for (MachineFunction::iterator I = MF.begin(), E = MF.end(); I != E; ) { - MachineBasicBlock *MBB = &*I++; - MadeChange |= HoistCommonCodeInSuccs(MBB); - } + for (MachineBasicBlock &MBB : llvm::make_early_inc_range(MF)) + MadeChange |= HoistCommonCodeInSuccs(&MBB); return MadeChange; } diff --git a/llvm/lib/CodeGen/CodeGenPrepare.cpp b/llvm/lib/CodeGen/CodeGenPrepare.cpp index 46b60dc..4a0a1d9 100644 --- a/llvm/lib/CodeGen/CodeGenPrepare.cpp +++ b/llvm/lib/CodeGen/CodeGenPrepare.cpp @@ -530,10 +530,9 @@ bool CodeGenPrepare::runOnFunction(Function &F) { while (MadeChange) { MadeChange = false; DT.reset(); - for (Function::iterator I = F.begin(); I != F.end(); ) { - BasicBlock *BB = &*I++; + for (BasicBlock &BB : llvm::make_early_inc_range(F)) { bool ModifiedDTOnIteration = false; - MadeChange |= optimizeBlock(*BB, ModifiedDTOnIteration); + MadeChange |= optimizeBlock(BB, ModifiedDTOnIteration); // Restart BB iteration if the dominator tree of the Function was changed if (ModifiedDTOnIteration) @@ -8029,9 +8028,8 @@ bool CodeGenPrepare::placeDbgValues(Function &F) { DominatorTree DT(F); for (BasicBlock &BB : F) { - for (BasicBlock::iterator BI = BB.begin(), BE = BB.end(); BI != BE;) { - Instruction *Insn = &*BI++; - DbgValueInst *DVI = dyn_cast<DbgValueInst>(Insn); + for (Instruction &Insn : llvm::make_early_inc_range(BB)) { + DbgValueInst *DVI = dyn_cast<DbgValueInst>(&Insn); if (!DVI) continue; diff --git a/llvm/lib/CodeGen/GlobalISel/Localizer.cpp b/llvm/lib/CodeGen/GlobalISel/Localizer.cpp index d45fdae..a1acc41 100644 --- a/llvm/lib/CodeGen/GlobalISel/Localizer.cpp +++ b/llvm/lib/CodeGen/GlobalISel/Localizer.cpp @@ -92,9 +92,8 @@ bool Localizer::localizeInterBlock(MachineFunction &MF, // Check if all the users of MI are local. // We are going to invalidation the list of use operands, so we // can't use range iterator. - for (auto MOIt = MRI->use_begin(Reg), MOItEnd = MRI->use_end(); - MOIt != MOItEnd;) { - MachineOperand &MOUse = *MOIt++; + for (MachineOperand &MOUse : + llvm::make_early_inc_range(MRI->use_operands(Reg))) { // Check if the use is already local. MachineBasicBlock *InsertMBB; LLVM_DEBUG(MachineInstr &MIUse = *MOUse.getParent(); diff --git a/llvm/lib/CodeGen/StackProtector.cpp b/llvm/lib/CodeGen/StackProtector.cpp index 9f229d5..8143523 100644 --- a/llvm/lib/CodeGen/StackProtector.cpp +++ b/llvm/lib/CodeGen/StackProtector.cpp @@ -440,9 +440,8 @@ bool StackProtector::InsertStackProtectors() { !TM->Options.EnableGlobalISel); AllocaInst *AI = nullptr; // Place on stack that stores the stack guard. - for (Function::iterator I = F->begin(), E = F->end(); I != E;) { - BasicBlock *BB = &*I++; - ReturnInst *RI = dyn_cast<ReturnInst>(BB->getTerminator()); + for (BasicBlock &BB : llvm::make_early_inc_range(*F)) { + ReturnInst *RI = dyn_cast<ReturnInst>(BB.getTerminator()); if (!RI) continue; @@ -530,23 +529,23 @@ bool StackProtector::InsertStackProtectors() { // Split the basic block before the return instruction. BasicBlock *NewBB = - BB->splitBasicBlock(CheckLoc->getIterator(), "SP_return"); + BB.splitBasicBlock(CheckLoc->getIterator(), "SP_return"); // Update the dominator tree if we need to. - if (DT && DT->isReachableFromEntry(BB)) { - DT->addNewBlock(NewBB, BB); - DT->addNewBlock(FailBB, BB); + if (DT && DT->isReachableFromEntry(&BB)) { + DT->addNewBlock(NewBB, &BB); + DT->addNewBlock(FailBB, &BB); } // Remove default branch instruction to the new BB. - BB->getTerminator()->eraseFromParent(); + BB.getTerminator()->eraseFromParent(); // Move the newly created basic block to the point right after the old // basic block so that it's in the "fall through" position. - NewBB->moveAfter(BB); + NewBB->moveAfter(&BB); // Generate the stack protector instructions in the old basic block. - IRBuilder<> B(BB); + IRBuilder<> B(&BB); Value *Guard = getStackGuard(TLI, M, B); LoadInst *LI2 = B.CreateLoad(B.getInt8PtrTy(), AI, true); Value *Cmp = B.CreateICmpEQ(Guard, LI2); |