diff options
| author | Teresa Johnson <tejohnson@google.com> | 2020-02-12 15:17:56 -0800 |
|---|---|---|
| committer | Teresa Johnson <tejohnson@google.com> | 2020-02-14 06:37:14 -0800 |
| commit | 2102ef8aad4ca0782cdac316afc8d306b04582c4 (patch) | |
| tree | fdf9bb51dfcc86cc83f31c8522de5c6a5c2da172 /llvm/lib/IR/ModuleSummaryIndex.cpp | |
| parent | b6a9fe209992789be3ed95664d25196361cfad34 (diff) | |
| download | llvm-2102ef8aad4ca0782cdac316afc8d306b04582c4.zip llvm-2102ef8aad4ca0782cdac316afc8d306b04582c4.tar.gz llvm-2102ef8aad4ca0782cdac316afc8d306b04582c4.tar.bz2 | |
Reenable "Always import constants" after compile time fixes
Summary:
Reenables importing of constants by default, which was disabled in
D73724 due to excessive thin link times. These inefficiencies were
fixed in D73851.
I re-measured thin link times for a number of binaries that had compile
time explosions with importing of constants previously and confirmed
they no longer have any notable increases with it enabled.
Reviewers: wmi, evgeny777
Subscribers: hiraditya, arphaman, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D74512
Diffstat (limited to 'llvm/lib/IR/ModuleSummaryIndex.cpp')
| -rw-r--r-- | llvm/lib/IR/ModuleSummaryIndex.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/llvm/lib/IR/ModuleSummaryIndex.cpp b/llvm/lib/IR/ModuleSummaryIndex.cpp index 0a43e17..d92943d 100644 --- a/llvm/lib/IR/ModuleSummaryIndex.cpp +++ b/llvm/lib/IR/ModuleSummaryIndex.cpp @@ -31,10 +31,8 @@ static cl::opt<bool> PropagateAttrs("propagate-attrs", cl::init(true), cl::Hidden, cl::desc("Propagate attributes in index")); -// FIXME: Enable again when thin link compile time regressions understood and -// addressed static cl::opt<bool> ImportConstantsWithRefs( - "import-constants-with-refs", cl::init(false), cl::Hidden, + "import-constants-with-refs", cl::init(true), cl::Hidden, cl::desc("Import constant global variables with references")); FunctionSummary FunctionSummary::ExternalNode = |