From 2102ef8aad4ca0782cdac316afc8d306b04582c4 Mon Sep 17 00:00:00 2001 From: Teresa Johnson Date: Wed, 12 Feb 2020 15:17:56 -0800 Subject: Reenable "Always import constants" after compile time fixes Summary: Reenables importing of constants by default, which was disabled in D73724 due to excessive thin link times. These inefficiencies were fixed in D73851. I re-measured thin link times for a number of binaries that had compile time explosions with importing of constants previously and confirmed they no longer have any notable increases with it enabled. Reviewers: wmi, evgeny777 Subscribers: hiraditya, arphaman, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D74512 --- llvm/lib/IR/ModuleSummaryIndex.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'llvm/lib/IR/ModuleSummaryIndex.cpp') diff --git a/llvm/lib/IR/ModuleSummaryIndex.cpp b/llvm/lib/IR/ModuleSummaryIndex.cpp index 0a43e17..d92943d 100644 --- a/llvm/lib/IR/ModuleSummaryIndex.cpp +++ b/llvm/lib/IR/ModuleSummaryIndex.cpp @@ -31,10 +31,8 @@ static cl::opt PropagateAttrs("propagate-attrs", cl::init(true), cl::Hidden, cl::desc("Propagate attributes in index")); -// FIXME: Enable again when thin link compile time regressions understood and -// addressed static cl::opt ImportConstantsWithRefs( - "import-constants-with-refs", cl::init(false), cl::Hidden, + "import-constants-with-refs", cl::init(true), cl::Hidden, cl::desc("Import constant global variables with references")); FunctionSummary FunctionSummary::ExternalNode = -- cgit v1.1