diff options
author | Fangrui Song <i@maskray.me> | 2022-03-15 19:24:41 -0700 |
---|---|---|
committer | Fangrui Song <i@maskray.me> | 2022-03-15 19:24:41 -0700 |
commit | 7c7702b318503e27ebc3c795a827aa85135cc130 (patch) | |
tree | c6c00a0e4c92b1e6a5da274324c3748224e2ba0c /llvm/lib/CodeGen/MachineModuleInfo.cpp | |
parent | 6a54776fe0092c251ee3783c0c25d14699467896 (diff) | |
download | llvm-7c7702b318503e27ebc3c795a827aa85135cc130.zip llvm-7c7702b318503e27ebc3c795a827aa85135cc130.tar.gz llvm-7c7702b318503e27ebc3c795a827aa85135cc130.tar.bz2 |
[ELF] Move section assignment from initializeSymbols to postParse
https://discourse.llvm.org/t/parallel-input-file-parsing/60164
initializeSymbols currently sets Defined::section and handles non-prevailing
COMDAT groups. Move the code to the parallel postParse to reduce work from the
single-threading code path and make parallel section initialization infeasible.
Postpone reporting duplicate symbol errors so that the messages have the
section information. (`Defined::section` is assigned in postParse and another
thread may not have the information).
* duplicated-synthetic-sym.s: BinaryFile duplicate definition (very rare) now
has no section information
* comdat-binding: `%t/w.o %t/g.o` leads to an undesired undefined symbol. This
is not ideal but we report a diagnostic to inform that this is unsupported.
(See release note)
* comdat-discarded-lazy.s: %tdef.o is unextracted. The new behavior (discarded
section error) makes more sense
* i386-comdat.s: switched to a better approach working around
.gnu.linkonce.t.__x86.get_pc_thunk.bx in glibc<2.32 for x86-32.
Drop the ancient no-longer-relevant workaround for __i686.get_pc_thunk.bx
Depends on D120640
Differential Revision: https://reviews.llvm.org/D120626
Diffstat (limited to 'llvm/lib/CodeGen/MachineModuleInfo.cpp')
0 files changed, 0 insertions, 0 deletions