aboutsummaryrefslogtreecommitdiff
path: root/clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
diff options
context:
space:
mode:
authorBen Shi <2283975856@qq.com>2024-01-31 12:50:23 +0800
committerGitHub <noreply@github.com>2024-01-31 12:50:23 +0800
commitc12f30c7ffedb2338d64d8f98a76ae56c497cfbb (patch)
tree9b4a71f8666a968dae18510f1395a4cc5800b62e /clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
parent150ab99583e252a809b94f89da2576a1fc808297 (diff)
downloadllvm-c12f30c7ffedb2338d64d8f98a76ae56c497cfbb.zip
llvm-c12f30c7ffedb2338d64d8f98a76ae56c497cfbb.tar.gz
llvm-c12f30c7ffedb2338d64d8f98a76ae56c497cfbb.tar.bz2
[clang][analyzer] Improve modeling of 'realpath' in StdLibraryFunctionsChecker (#79939)
Diffstat (limited to 'clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp')
-rw-r--r--clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp8
1 files changed, 6 insertions, 2 deletions
diff --git a/clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
index be26f55..0c6293e6 100644
--- a/clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
@@ -2992,12 +2992,16 @@ void StdLibraryFunctionsChecker::initFunctionSummaries(
// char *realpath(const char *restrict file_name,
// char *restrict resolved_name);
- // FIXME: Improve for errno modeling.
+ // FIXME: If the argument 'resolved_name' is not NULL, macro 'PATH_MAX'
+ // should be defined in "limits.h" to guarrantee a success.
addToFunctionSummaryMap(
"realpath",
Signature(ArgTypes{ConstCharPtrRestrictTy, CharPtrRestrictTy},
RetType{CharPtrTy}),
- Summary(NoEvalCall).ArgConstraint(NotNull(ArgNo(0))));
+ Summary(NoEvalCall)
+ .Case({NotNull(Ret)}, ErrnoMustNotBeChecked, GenericSuccessMsg)
+ .Case({IsNull(Ret)}, ErrnoNEZeroIrrelevant, GenericFailureMsg)
+ .ArgConstraint(NotNull(ArgNo(0))));
QualType CharPtrConstPtr = getPointerTy(getConstTy(CharPtrTy));