From c12f30c7ffedb2338d64d8f98a76ae56c497cfbb Mon Sep 17 00:00:00 2001 From: Ben Shi <2283975856@qq.com> Date: Wed, 31 Jan 2024 12:50:23 +0800 Subject: [clang][analyzer] Improve modeling of 'realpath' in StdLibraryFunctionsChecker (#79939) --- clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp') diff --git a/clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp index be26f55..0c6293e6 100644 --- a/clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp @@ -2992,12 +2992,16 @@ void StdLibraryFunctionsChecker::initFunctionSummaries( // char *realpath(const char *restrict file_name, // char *restrict resolved_name); - // FIXME: Improve for errno modeling. + // FIXME: If the argument 'resolved_name' is not NULL, macro 'PATH_MAX' + // should be defined in "limits.h" to guarrantee a success. addToFunctionSummaryMap( "realpath", Signature(ArgTypes{ConstCharPtrRestrictTy, CharPtrRestrictTy}, RetType{CharPtrTy}), - Summary(NoEvalCall).ArgConstraint(NotNull(ArgNo(0)))); + Summary(NoEvalCall) + .Case({NotNull(Ret)}, ErrnoMustNotBeChecked, GenericSuccessMsg) + .Case({IsNull(Ret)}, ErrnoNEZeroIrrelevant, GenericFailureMsg) + .ArgConstraint(NotNull(ArgNo(0)))); QualType CharPtrConstPtr = getPointerTy(getConstTy(CharPtrTy)); -- cgit v1.1