aboutsummaryrefslogtreecommitdiff
path: root/clang/lib/Frontend/CompilerInvocation.cpp
diff options
context:
space:
mode:
authorYoungsuk Kim <youngsuk.kim@hpe.com>2024-09-19 13:36:53 -0500
committerYoungsuk Kim <youngsuk.kim@hpe.com>2024-09-19 14:56:45 -0500
commitac664697c54cf2ffa9ebef0215f734bcca3b718f (patch)
treee51c26852b32915c90c3f4ebf399827f8b45324d /clang/lib/Frontend/CompilerInvocation.cpp
parent434c9c50f99b1ad4e551c64af93287869389b087 (diff)
downloadllvm-ac664697c54cf2ffa9ebef0215f734bcca3b718f.zip
llvm-ac664697c54cf2ffa9ebef0215f734bcca3b718f.tar.gz
llvm-ac664697c54cf2ffa9ebef0215f734bcca3b718f.tar.bz2
[clang] Tidy uses of raw_string_ostream (NFC)
As specified in the docs, 1) raw_string_ostream is always unbuffered and 2) the underlying buffer may be used directly ( 65b13610a5226b84889b923bae884ba395ad084d for further reference ) * Don't call raw_string_ostream::flush(), which is essentially a no-op. * Avoid unneeded calls to raw_string_ostream::str(), to avoid excess indirection.
Diffstat (limited to 'clang/lib/Frontend/CompilerInvocation.cpp')
-rw-r--r--clang/lib/Frontend/CompilerInvocation.cpp4
1 files changed, 1 insertions, 3 deletions
diff --git a/clang/lib/Frontend/CompilerInvocation.cpp b/clang/lib/Frontend/CompilerInvocation.cpp
index 32628c5..de6776b 100644
--- a/clang/lib/Frontend/CompilerInvocation.cpp
+++ b/clang/lib/Frontend/CompilerInvocation.cpp
@@ -817,7 +817,6 @@ static bool RoundTrip(ParseFn Parse, GenerateFn Generate,
llvm::sys::printArg(OS, Arg, /*Quote=*/true);
OS << ' ';
}
- OS.flush();
return Buffer;
};
@@ -1186,7 +1185,6 @@ static bool ParseAnalyzerArgs(AnalyzerOptions &Opts, ArgList &Args,
os << " ";
os << Args.getArgString(i);
}
- os.flush();
return Diags.getNumErrors() == NumErrorsBefore;
}
@@ -3735,7 +3733,7 @@ void CompilerInvocationBase::GenerateLangArgs(const LangOptions &Opts,
llvm::interleave(
Opts.OMPTargetTriples, OS,
[&OS](const llvm::Triple &T) { OS << T.str(); }, ",");
- GenerateArg(Consumer, OPT_fopenmp_targets_EQ, OS.str());
+ GenerateArg(Consumer, OPT_fopenmp_targets_EQ, Targets);
}
if (!Opts.OMPHostIRFile.empty())