From ac664697c54cf2ffa9ebef0215f734bcca3b718f Mon Sep 17 00:00:00 2001 From: Youngsuk Kim Date: Thu, 19 Sep 2024 13:36:53 -0500 Subject: [clang] Tidy uses of raw_string_ostream (NFC) As specified in the docs, 1) raw_string_ostream is always unbuffered and 2) the underlying buffer may be used directly ( 65b13610a5226b84889b923bae884ba395ad084d for further reference ) * Don't call raw_string_ostream::flush(), which is essentially a no-op. * Avoid unneeded calls to raw_string_ostream::str(), to avoid excess indirection. --- clang/lib/Frontend/CompilerInvocation.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'clang/lib/Frontend/CompilerInvocation.cpp') diff --git a/clang/lib/Frontend/CompilerInvocation.cpp b/clang/lib/Frontend/CompilerInvocation.cpp index 32628c5..de6776b 100644 --- a/clang/lib/Frontend/CompilerInvocation.cpp +++ b/clang/lib/Frontend/CompilerInvocation.cpp @@ -817,7 +817,6 @@ static bool RoundTrip(ParseFn Parse, GenerateFn Generate, llvm::sys::printArg(OS, Arg, /*Quote=*/true); OS << ' '; } - OS.flush(); return Buffer; }; @@ -1186,7 +1185,6 @@ static bool ParseAnalyzerArgs(AnalyzerOptions &Opts, ArgList &Args, os << " "; os << Args.getArgString(i); } - os.flush(); return Diags.getNumErrors() == NumErrorsBefore; } @@ -3735,7 +3733,7 @@ void CompilerInvocationBase::GenerateLangArgs(const LangOptions &Opts, llvm::interleave( Opts.OMPTargetTriples, OS, [&OS](const llvm::Triple &T) { OS << T.str(); }, ","); - GenerateArg(Consumer, OPT_fopenmp_targets_EQ, OS.str()); + GenerateArg(Consumer, OPT_fopenmp_targets_EQ, Targets); } if (!Opts.OMPHostIRFile.empty()) -- cgit v1.1