Make llvm::StringRef to std::string conversions explicit.

This is how it should've been and brings it more in line with
std::string_view. There should be no functional change here.

This is mostly mechanical from a custom clang-tidy check, with a lot of
manual fixups. It uncovers a lot of minor inefficiencies.

This doesn't actually modify StringRef yet, I'll do that in a follow-up.

1 files changed, 2 insertions, 2 deletions

diff --git a/clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp b/clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp
index ce8d00f..164c9fe9 100644
--- a/clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp
@@ -98,9 +98,9 @@ void UseUsingCheck::check(const MatchFinder::MatchResult &Result) {
   // If typedef contains a full struct/class declaration, extract its full text.
   if (LastCxxDeclRange.isValid() && ReplaceRange.fullyContains(LastCxxDeclRange)) {
     bool Invalid;
-    Type =
+    Type = std::string(
         Lexer::getSourceText(CharSourceRange::getTokenRange(LastCxxDeclRange),
-                             *Result.SourceManager, getLangOpts(), &Invalid);
+                             *Result.SourceManager, getLangOpts(), &Invalid));
     if (Invalid)
       return;
   }