From adcd02683856c30ba6f349279509acecd90063df Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Tue, 28 Jan 2020 20:23:46 +0100 Subject: Make llvm::StringRef to std::string conversions explicit. This is how it should've been and brings it more in line with std::string_view. There should be no functional change here. This is mostly mechanical from a custom clang-tidy check, with a lot of manual fixups. It uncovers a lot of minor inefficiencies. This doesn't actually modify StringRef yet, I'll do that in a follow-up. --- clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp') diff --git a/clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp b/clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp index ce8d00f..164c9fe9 100644 --- a/clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp +++ b/clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp @@ -98,9 +98,9 @@ void UseUsingCheck::check(const MatchFinder::MatchResult &Result) { // If typedef contains a full struct/class declaration, extract its full text. if (LastCxxDeclRange.isValid() && ReplaceRange.fullyContains(LastCxxDeclRange)) { bool Invalid; - Type = + Type = std::string( Lexer::getSourceText(CharSourceRange::getTokenRange(LastCxxDeclRange), - *Result.SourceManager, getLangOpts(), &Invalid); + *Result.SourceManager, getLangOpts(), &Invalid)); if (Invalid) return; } -- cgit v1.1