- Sep 15, 2015
-
-
Rod Vagg authored
-
Rod Vagg authored
* buffer: Fixed a minor errors that was causing crashes (Michaël Zasso) #2635, * child_process: Fix error that was causing crashes (Evan Lucas) #2727 * crypto: Replace use of rwlocks, unsafe on Windows XP / 2003 (Ben Noordhuis) #2723 * libuv: Upgrade from 1.7.3 to 1.7.4 (Saúl Ibarra Corretgé) #2817 * node: Fix faulty process.release.libUrl on Windows (Rod Vagg) #2699 * node-gyp: Float v3.0.3 which has improved support for Node.js and io.js v0.10 to v4+ (Rod Vagg) #2700 * npm: Upgrade to version 2.14.3 from 2.13.3, includes a security update, see https://github.com/npm/npm/releases/tag/v2.14.2 for more details, (Kat Marchán) #2696. * timers: Improved timer performance from porting the 0.12 implementation, plus minor fixes (Jeremiah Senkpiel) #2540, (Julien Gilli) nodejs/node-v0.x-archive#8751 nodejs/node-v0.x-archive#8905 PR-URL: https://github.com/nodejs/node/pull/2698
-
Sakthipriyan Vairamani authored
Make `make clean` cleanup the generated tap file as well. Fixes: #2834 PR-URL: #2837 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org>
-
Sakthipriyan Vairamani authored
By default the logfile is opened in append mode. This commit makes sure that the file is opened in write-binary mode, so that the file will be created if it doesn't exist or overwrite if it exists. Fixes: #2834 PR-URL: #2837 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org>
-
Brendan Ashworth authored
This commit refactors LazyTransform from the crypto implementation (lib/crypto.js) into an internal module (not publicy accessible) in internal/streams/lazy_transform.js. This promotes a more modular core design and removes code bloat in crypto, as LazyTransform didn't specifically have anything to do with cryptography, but rather a fast way to support two APIs on a stream. PR-URL: https://github.com/nodejs/node/pull/2566 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com>
-
Fedor Indutny authored
Socket resume may happen on a next tick, and in following scenario: 1. `socket.resume()` 2. `socket._handle.close()` 3. `socket._handle = null;` The `_resume` will be invoked with empty `._handle` property. There is nothing bad about it, and we should just ignore the `resume`/`pause` events in this case. Same applies to the unconsuming of socket on adding `data` and/or `readable` event listeners. Fix: https://github.com/nodejs/node/issues/2821 PR-URL: https://github.com/nodejs/node/pull/2824 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Kat Marchán authored
No more cherry-picked io patches. hooray. PR-URL: https://github.com/nodejs/node/pull/2822 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/2822 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Matt Loring authored
The polyfill is only needed if incorrect command line arguments are passed to the script so it was missed in initial testing. PR-URL: https://github.com/nodejs/node/pull/2694 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Matt Loring authored
Per the discussion on #2471, the JS symbols checked for by this test were occasionally too deep in the stack and were being ignored by the tick processor. I have addressed this by increasing the stack depth inspected by the tick processor and looking for the eval symbol which is more likely to be present. Additional flakiness was caused by occasional misses of the code creation event for the JS function being executed. I now have separate code snippets to test for JS and C++ symbols and if the code creation event is missed for the JS symbol test then I check for a percentage of UNKNOWN symbols in processed output. This is considered a success as the processing scripts in the node repository are still correctly processing the ticks recieved from the v8 scripts. Further investigation is needed into the v8 profiling scripts to determine why code creation events are being missed. PR-URL: https://github.com/nodejs/node/pull/2694 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Danny Nemer authored
PR-URL: https://github.com/nodejs/node/pull/2827 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Ionică Bizău authored
- Fixed typo: "insallation" -> "installation" - Added an "that" in a sentence where it was needed for clarity. PR-URL: https://github.com/nodejs/node/pull/2852 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Mike Tunnicliffe authored
Refs: https://github.com/nodejs/node/issues/2413 PR-URL: https://github.com/nodejs/node/pull/2826 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Roman Klauke authored
Other methods like `After` already use ZCtxt as the source for Enviroment/ v8::Isolate objects, this commit applies the same style to the other missing methods (`After sync` and `Write`) PR-URL: https://github.com/nodejs/node/pull/2547 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rich Trott authored
Remove test file that has been in disabled from its very first commit (9ccf0e52) in 2011. It is a test for https://github.com/nodejs/node-v0.x-archive/issues/670 from 2011. There are no assertions in the test. In that regard, it is more debugging code than a test. PR-URL: https://github.com/nodejs/node/pull/2841 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Yosuke Furukawa <yosuke.furukawa@gmail.com>
-
Jeremiah Senkpiel authored
`process.stdout` always blocks as of 20176a98 `WritableState.buffer` is `getBuffer()` as of 91586661 PR-URL: https://github.com/nodejs/node/pull/2549 Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Rich Trott authored
For whatever reason, the CI win2012 machine was timing out on the internet test-dns file. Split out ipv4 and ipv6 specific tests to separate files so tests do not time out. (Each file is given a 60 second timeout on CI. Tests within a file are run in sequence.) PR-URL: https://github.com/nodejs/node/pull/2802 Fixes: https://github.com/nodejs/node/issues/2468 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Rich Trott authored
test-dgram-broadcast-multi-process.js and test-dgram-multicast-multi-process.js were failing on Pi 1 because the test was timing out. Changed static 5000ms timeout to a dynamically determined timeout based on the processor using common.platformTimeout(). PR-URL: https://github.com/nodejs/node/pull/2808 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Sakthipriyan Vairamani authored
As it is, the TAP result shows an extra hyphen in front of test names. Sample: ci.nodejs.org/job/node-test-commit-osx/nodes=osx1010/454/tapResults/ This patch removes the extra hyphen. PR-URL: https://github.com/nodejs/node/pull/2718 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
- Sep 12, 2015
-
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2737 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Fedor Indutny authored
Allow listening on reused dgram ports in cluster workers. Fix: https://github.com/joyent/node/issues/9261 PR-URL: https://github.com/nodejs/node/pull/2548 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2717 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Saúl Ibarra Corretgé authored
PR-URL: https://github.com/nodejs/node/pull/2817 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Minwoo Jung authored
"Calls" is used frequently throughout the docs except for this line. Use "Calls" over "Executes" to make it consistent. PR-URL: https://github.com/nodejs/node/pull/2800 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rich Trott authored
Operating systems can and do return invalid hostnames if that's what they have (for example) in /etc/hosts. Test passes if no error is thrown and the hostname string is not empty. Fixes: https://github.com/nodejs/node/issues/2468 PR-URL: https://github.com/nodejs/node/pull/2785 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Anne-Gaelle Colom authored
behaviour -> behavior PR-URL: https://github.com/nodejs/node/pull/2784 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Fedor Indutny authored
Do not let the module struct to be deallocated by `uv_dlclose` before reading data from it. PR-URL: https://github.com/nodejs/node/pull/2792 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Yosuke Furukawa <yosuke.furukawa@gmail.com>
-
Anne-Gaelle Colom authored
PR-URL: https://github.com/nodejs/node/pull/2765 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Brian White authored
Fixes: https://github.com/nodejs/node/issues/2779 PR-URL: https://github.com/nodejs/node/pull/2781 Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Rich Trott authored
FreeBSD does not support the V4MAPPED flag so expect an error. This is a partial fix for https://github.com/nodejs/node/issues/2468. It only fixes it on FreeBSD. Failures on other platforms are due to other reasons and need to be fixed separately. PR-URL: https://github.com/nodejs/node/pull/2724 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Fixes: https://github.com/nodejs/node/issues/2468
-
Rich Trott authored
This fixes a minor typographical error in the Assertion Testing doc. PR-URL: https://github.com/nodejs/node/pull/2728 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Karl Skomski authored
It was previously ignored by features.gypi and therefore enabled by default for release builds. See https://code.google.com/p/chromium/issues/detail?id=318206 PR-URL: https://github.com/nodejs/node/pull/2731 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rod Vagg authored
* support process.release * support all io.js versions * support node v4+ including new download locations * enable delay-load hook by default by default * download header-only tarballs instead of full source See https://github.com/nodejs/node-gyp/pull/711 for full details PR-URL: https://github.com/nodejs/node/pull/2700 Reviewed-By:
Forrest L Norvell <forrest@npmjs.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2699 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org>
-
Evan Lucas authored
Previously, in _validateStdio we were using stdio.fd || stdio. If stdio.fd was falsy (or 0 in the case of stdin), then the entire stdio object would be passed which could cause a crash. Fixes: https://github.com/nodejs/node/issues/2721 PR-URL: https://github.com/nodejs/node/pull/2727 Reviewed-By:
silverwind - Roman Reiss <me@silverwind.io> Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
indutny - Fedor Indutny <fedor.indutny@gmail.com>
-
Ben Noordhuis authored
It was pointed out by Zhou Ran that the Windows XP implementation of uv_rwlock_rdlock() and friends may unlock the inner write mutex on a different thread than the one that locked it, resulting in undefined behavior. The only place that uses rwlocks is the crypto module. Make that use normal (simple) mutexes instead. OpenSSL's critical sections are generally very short, with exclusive access outnumbering shared access by a factor of three or more, so it's not as if using rwlocks gives a decisive performance advantage. PR-URL: https://github.com/nodejs/node/pull/2723 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Rod Vagg authored
Update AUTHORS list using tools/update-authors.sh
-
- Sep 07, 2015
-
-
Ben Noordhuis authored
cpplint uses the top-level .git directory to determine what the root is for #include guards. If it doesn't find a .git directory, it walks up all the way to the system root and subsequently complains that guards must be written as HOME_USER_SRC_NODE_SRC_FILENAME_H_. This commit replaces the .git-based path munging with a fixed root path relative to the location of the cpplint script, making it possible to successfully run `make test` from an extracted tarball. Fixes: https://github.com/nodejs/node/issues/2693 PR-URL: https://github.com/nodejs/node/pull/2710 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Kat Marchán authored
This patch should make the tests pass on the downstreamed npm. PR-URL: https://github.com/nodejs/node/pull/2696 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/2696 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-